Skip to content

[ISSUE #11512] fix(common): parse compression type with Locale.ROOT #11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharanggupta wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #11512] fix(common): parse compression type with Locale.ROOT #11513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion common/src/main/java/org/apache/rocketmq/common/compression/CompressionType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package org.apache.rocketmq.common.compression;

import java.util.Locale;

import org.apache.rocketmq.common.sysflag.MessageSysFlag;

public enum CompressionType {
Expand Down Expand Up @@ -49,7 +51,7 @@ public int getValue() {
}

public static CompressionType of(String name) {
switch (name.trim().toUpperCase()) {
switch (name.trim().toUpperCase(Locale.ROOT)) {
case "LZ4":
return CompressionType.LZ4;
case "ZSTD":
Expand Down
14 changes: 14 additions & 0 deletions common/src/test/java/org/apache/rocketmq/common/compression/CompressionTypeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
package org.apache.rocketmq.common.compression;

import java.util.Locale;

import org.apache.rocketmq.common.sysflag.MessageSysFlag;
import org.junit.Test;

Expand All @@ -39,6 +41,18 @@ public void testCompressionTypeOf() {
assertThrows(RuntimeException.class, () -> CompressionType.of("UNKNOWN"));
}

@Test
public void testCompressionTypeOfIsLocaleIndependent() {
Locale previous = Locale.getDefault();
try {
Locale.setDefault(new Locale("tr", "TR"));
assertEquals(CompressionType.ZLIB, CompressionType.of("zlib"));
assertEquals(CompressionType.ZLIB, CompressionType.of("Zlib"));
} finally {
Locale.setDefault(previous);
}
}

@Test
public void testCompressionTypeFindByValue() {
assertEquals(CompressionType.LZ4, CompressionType.findByValue(1));
Expand Down
Loading