Repository navigation
[ISSUE #11512] fix(common): parse compression type with Locale.ROOT - #11513
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
lwclover
approved these changes
Nov 13, 2026
Member
|
LGTM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11513 +/- ##
=============================================
- Coverage 49.79% 49.78% -0.01%
+ Complexity 14407 14404 -3
=============================================
Files 1391 1391
Lines 103381 103381
Branches 13529 13529
=============================================
- Hits 51477 51471 -6
- Misses 45686 45688 +2
- Partials 6218 6222 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #11512
Brief Description
CompressionType.ofupper-cased the name with the default locale, so under the Turkish locale a lower/mixed-case value containingi(e.g.zlib->ZLİB) missed the switch and threw at producer start-up. Parse withLocale.ROOTand add a regression test.How Did You Test This Change?
Added
CompressionTypeTest.testCompressionTypeOfIsLocaleIndependent(sets default locale to tr-TR, assertsof("zlib")/of("Zlib")return ZLIB); fullCompressionTypeTestpasses.