Repository navigation
[To dev/1.3] Avoid stack traces for expected REST query errors - #19280
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #19280 +/- ##
==========================================
Coverage 47.49% 47.49%
Complexity 221 221
==========================================
Files 3678 3678
Lines 252123 252126 +3
Branches 31360 31359 -1
==========================================
+ Hits 119740 119751 +11
+ Misses 132383 132375 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



REST v1 and v2 unconditionally logged exception stack traces, including invalid SQL and other expected query failures. Extract the logging policy from
ErrorHandlingUtils.onQueryExceptionand share it with both REST exception handlers: expected errors log at INFO without a stack trace, storage-engine-not-ready errors remain silent, and other errors retain WARN stack traces. Existing REST response codes and messages are unchanged.Add parameterized regression coverage for both REST versions, checking response compatibility, log levels, and the presence or absence of stack traces.
Validation:
mvn clean test -pl iotdb-core/datanode -am -Dtest=ExceptionHandlerTest,ErrorHandlingUtilsTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=falsewith JDK 17. Build passed; all 12 tests passed. Spotless andgit diff --checkpassed.