Skip to content

Assert expected exceptions are actually thrown #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Oct 29, 2026
Merged

Assert expected exceptions are actually thrown #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,8 @@ void testFailed() throws Exception {
Mockito.verify(callback).failed(boom);
Mockito.verify(callback, Mockito.never()).cancelled();

try {
future.get();
} catch (final ExecutionException ex) {
Assertions.assertSame(boom, ex.getCause());
}
final ExecutionException ex = assertThrows(ExecutionException.class, future::get);
Assertions.assertSame(boom, ex.getCause());
Assertions.assertTrue(future.isDone());
Assertions.assertFalse(future.isCancelled());
}
Expand Down Expand Up @@ -162,11 +159,9 @@ void testAsyncFailed() throws Exception {
});
t.setDaemon(true);
t.start();
try {
future.get(60, TimeUnit.SECONDS);
} catch (final ExecutionException ex) {
Assertions.assertSame(boom, ex.getCause());
}
final ExecutionException ex = assertThrows(ExecutionException.class, () ->
future.get(60, TimeUnit.SECONDS));
Assertions.assertSame(boom, ex.getCause());
Assertions.assertTrue(future.isDone());
Assertions.assertFalse(future.isCancelled());
}
Expand Down
8 changes: 3 additions & 5 deletions ...e5/src/test/java/org/apache/hc/core5/http/nio/support/classic/TestSharedOutputBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,9 @@ void testMultithreadingWriteStreamAbort() throws Exception {
});

Assertions.assertEquals(Boolean.TRUE, task2.get(TIMEOUT.getDuration(), TIMEOUT.getTimeUnit()));
try {
task1.get(TIMEOUT.getDuration(), TIMEOUT.getTimeUnit());
} catch (final ExecutionException ex) {
Assertions.assertInstanceOf(InterruptedIOException.class, ex.getCause());
}
final ExecutionException ex = Assertions.assertThrows(ExecutionException.class, () ->
task1.get(TIMEOUT.getDuration(), TIMEOUT.getTimeUnit()));
Assertions.assertInstanceOf(InterruptedIOException.class, ex.getCause());
}

@Test
Expand Down
Loading