Repository navigation
Conversation
TestBasicFuture#testFailed, #testAsyncFailed and TestSharedOutputBuffer#testMultithreadingWriteStreamAbort checked the ExecutionException only in a catch block, so they still passed if get() returned normally. Use assertThrows so a missing failure fails the test.
Member
|
Thank you @sharanggupta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBasicFuture#testFailed,#testAsyncFailedandTestSharedOutputBuffer#testMultithreadingWriteStreamAbortchecked the expected exception only inside a catch block, so they still passed if the call returned normally. They now useassertThrows; withBasicFuture.failed()dropping the exception orabort()silently discarding writes, the old versions stay green and the new ones fail.