Skip to content

reject dot-segment path parameters in RestInvocationHandler #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Oct 28, 2026
Merged

reject dot-segment path parameters in RestInvocationHandler #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...arta-rest-client/src/main/java/org/apache/hc/client5/http/rest/RestInvocationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ private Object executeRequest(final ResourceMethod rm,
switch (param.getType()) {
case PATH:
Args.check(paramValue != null, "Path parameter '%s' must not be null", param.getName());
Args.check(!".".equals(paramValue) && !"..".equals(paramValue),
"Path parameter '%s' must not be a '.' or '..' segment", param.getName());
pathParams.put(paramName, paramValue);
break;
case QUERY:
Expand Down
8 changes: 8 additions & 0 deletions ...arta-rest-client/src/test/java/org/apache/hc/client5/http/rest/RestClientBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,14 @@ void testNullPathParamThrows() {
assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> api.echoPath(null));
}

@Test
void testDotSegmentPathParamThrows() {
final EchoPathApi api = proxy(EchoPathApi.class);
assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> api.echoPath(".."));
assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> api.echoPath("."));
assertThat(api.echoPath("..a")).isEqualTo("..a");
}

@Test
void testQueryParamSpaceEncodedAsPercent20() {
final EchoApi api = proxy(EchoApi.class);
Expand Down
Loading