Repository navigation
reject dot-segment path parameters in RestInvocationHandler - #907
Merged
Merged
Conversation
A @PathParam value of "." or ".." was appended as a literal dot segment, so once the request path is normalized the caller-supplied value moves the request out of the resource the template maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dot-segment path parameters escape their segment in RestInvocationHandler
URIBuilder.appendPathSegmentsencodes/and%in a@PathParamvalue but leaves.and..as literal dot segments, so@Path("/api/accounts/{id}/profile")called withid = ".."sendsGET /api/accounts/../profile, which resolves to/api/profileunder RFC 3986 dot-segment removal (the same issue Retrofit fixed as CVE-2018-1000850). Rejected the two values next to the existing null check; percent-encoding the dots would not help since normalization treats%2Eas..