Skip to content

fix: run the Pose cases of the RPC serialization tests #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoelStephensUnity wants to merge 3 commits into
base: develop-3.x.x
Choose a base branch
from
Open

fix: run the Pose cases of the RPC serialization tests #4220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1a4505
fix: run the Pose cases of the RPC serialization tests
NoelStephensUnity Oct 26, 2026
32784f3
Merge branch 'develop-3.x.x' into fix/rpc-pose-test-yield
NoelStephensUnity Oct 27, 2026
12d8fe3
Merge develop-3.x.x into fix/rpc-pose-test-yield
netcode-ci-service Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions com.unity.netcode.gameobjects/Tests/Runtime/Rpc/RpcTypeSerializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,7 +1261,7 @@ public IEnumerator WhenSendingAValueTypeOverAnRpc_ValuesAreSerializedCorrectly(
}
else if (testType == typeof(Pose))
{
TestValueType(
yield return TestValueType(
new Pose(new Vector3(5, 10, 15), new Quaternion(20, 25, 30, 35)),
new Pose(new Vector3(40, 45, 50), new Quaternion(55, 60, 65, 70)));
}
Expand Down Expand Up @@ -1468,7 +1468,7 @@ public IEnumerator WhenSendingAnArrayOfValueTypesOverAnRpc_ValuesAreSerializedCo
}
else if (testType == typeof(Pose))
{
TestValueTypeArray(
yield return TestValueTypeArray(
new Pose[] { new Pose(new Vector3(5, 10, 15), new Quaternion(20, 25, 30, 35)), new Pose(new Vector3(40, 45, 50), new Quaternion(55, 60, 65, 70)) },
new Pose[] { new Pose(new Vector3(75, 80, 85), new Quaternion(90, 95, 100, 105)), new Pose(new Vector3(110, 115, 120), new Quaternion(125, 130, 135, 140)), new Pose(new Vector3(145, 150, 155), new Quaternion(160, 165, 170, 175)) });
}
Expand Down Expand Up @@ -1715,7 +1715,7 @@ public IEnumerator WhenSendingANativeArrayOfValueTypesOverAnRpc_ValuesAreSeriali
}
else if (testType == typeof(Pose))
{
TestValueTypeNativeArray(
yield return TestValueTypeNativeArray(
new NativeArray<Pose>(new Pose[] { new Pose(new Vector3(5, 10, 15), new Quaternion(20, 25, 30, 35)), new Pose(new Vector3(40, 45, 50), new Quaternion(55, 60, 65, 70)) }, Allocator.Persistent),
new NativeArray<Pose>(new Pose[] { new Pose(new Vector3(75, 80, 85), new Quaternion(90, 95, 100, 105)), new Pose(new Vector3(110, 115, 120), new Quaternion(125, 130, 135, 140)), new Pose(new Vector3(145, 150, 155), new Quaternion(160, 165, 170, 175)) }, Allocator.Persistent));
}
Expand Down Expand Up @@ -1963,7 +1963,7 @@ public IEnumerator WhenSendingANativeListOfValueTypesOverAnRpc_ValuesAreSerializ
}
else if (testType == typeof(Pose))
{
TestValueTypeNativeList(
yield return TestValueTypeNativeList(
new NativeList<Pose>(Allocator.Persistent) { new Pose(new Vector3(5, 10, 15), new Quaternion(20, 25, 30, 35)), new Pose(new Vector3(40, 45, 50), new Quaternion(55, 60, 65, 70)) },
new NativeList<Pose>(Allocator.Persistent) { new Pose(new Vector3(75, 80, 85), new Quaternion(90, 95, 100, 105)), new Pose(new Vector3(110, 115, 120), new Quaternion(125, 130, 135, 140)), new Pose(new Vector3(145, 150, 155), new Quaternion(160, 165, 170, 175)) });
}
Expand Down
Loading