Repository navigation
fix: run the Pose cases of the RPC serialization tests - #4220
Open
NoelStephensUnity wants to merge 3 commits into
Open
NoelStephensUnity wants to merge 3 commits into
NoelStephensUnity wants to merge 3 commits into
Conversation
The Pose branches called the coroutine helpers without yield return, so the Pose cases passed without running and their native collections were never disposed.
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The four added yields correctly execute the existing Pose RPC test coroutines. I examined all changed branches, matching RPC methods, assertions, native collection disposal, and compilation guards; no actionable issues were found.
Reviewed commit a1a4505
🤖 Helpful? 👍/👎
NoelStephensUnity
enabled auto-merge (squash)
October 27, 2026 17:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The
Posecases ofRpcTypeSerializationTestspassed without running. Their branches called the coroutine helpers withoutyield return, so the RPCs were never sent or checked, and theNativeArray/NativeListcases never disposed their collections. Those collections are the 6 allocations left after #4219 in the unified suite's leak report.PR Scope:
yield returnto all fourPosebranches: single value, managed array,NativeArrayandNativeList.Jira ticket
None.
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsRpcTypeSerializationTests:Server132/132 andUnifiedServer132/132 passed, with allPosecases now running.Does the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
Not needed: targets develop-3.x.x. The same
Posebranches exist on develop-2.0.0 if a port is wanted.Backports
None.