Skip to content

Preserve alias diagnostics after executable commands in DSC ASTs #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christoph Bergmeister (bergmeister) merged 2 commits into from
Oct 29, 2026
Merged

Preserve alias diagnostics after executable commands in DSC ASTs #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ca729
Initial plan
Copilot Oct 29, 2026
5eafbae
Guard following-line DSC resource detection
Copilot Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Rules/AvoidAlias.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ private bool IsFollowingLineDscResourceBody(ScriptBlockExpressionAst body)
return false;
}

return GetDscResourceBody(declaration) == body;
string declarationCommandName = declaration.GetCommandName();
return GetDscResourceBody(declaration) == body
&& String.IsNullOrEmpty(Helper.Instance.GetCmdletNameFromAlias(declarationCommandName))
&& (String.Equals(declarationCommandName, "Node", StringComparison.OrdinalIgnoreCase)
|| Helper.Instance.GetCommandInfo(declarationCommandName) == null);
}

return false;
Expand Down
23 changes: 23 additions & 0 deletions Tests/Rules/AvoidUsingAlias.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,29 @@ Configuration PackageTest {
}
}

It "does not mistake following-line blocks after executable commands for DSC resources" {
$target = @'
{
Write-Output value
{
Verb Argument {}
}
}
'@
$ast = [System.Management.Automation.Language.Parser]::ParseInput($target, [ref]$null, [ref]$null)
$body = $ast.EndBlock.Statements[0].PipelineElements[0].Expression.Copy()
$configuration = [System.Management.Automation.Language.ConfigurationDefinitionAst]::new(
$ast.Extent, $body, 'Resource',
[System.Management.Automation.Language.StringConstantExpressionAst]::new($ast.Extent, 'Test', 'BareWord'))
$rule = [Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules.AvoidAlias]::new()

$violations = @($rule.AnalyzeScript($configuration, $null))

$violations.Count | Should -Be 1
$violations[0].Extent.Text | Should -Be 'Verb'
$violations[0].SuggestedCorrections[0].Text | Should -Be 'Get-Verb'
}

It "does not pair following-line blocks with commands when the block has redirections or a statement separator intervenes" {
$target = @'
{
Expand Down
Loading