Repository navigation
Preserve alias diagnostics after executable commands in DSC ASTs - #2293
Merged
Christoph Bergmeister (bergmeister) merged 2 commits intoOct 29, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Preserve alias diagnostics after executable commands in DSC ASTs
Oct 29, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the DSC fallback heuristic update and its alias-diagnostic regression test.
No open issues 🎉
What changed in this PR
This PR refines the DSC AST fallback heuristic so executable commands followed by standalone blocks do not suppress alias diagnostics inside those blocks.
Changes:
- Apply alias and command-resolution checks to following-line resource candidates while preserving the
Nodeexception. - Add a regression test verifying that
Verbstill receives theGet-Verbcorrection afterWrite-Output.
| File | Description |
|---|---|
| Tests/Rules/AvoidUsingAlias.tests.ps1 | Tests alias diagnostics inside a standalone block following an executable command. |
| Rules/AvoidAlias.cs | Filters following-line DSC resource candidates using alias and command resolution. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 29, 2026 11:23
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 29, 2026 11:23
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2294
October 29, 2026 11:23
Christoph Bergmeister (bergmeister)
merged commit Oct 29, 2026
e51412d
into
copilot/fix-auto-correct-aliases
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-comments-review-thread-2270
branch
October 29, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback DSC AST heuristic could mistake a known executable command followed by a standalone block for a resource declaration, suppressing alias diagnostics inside the block.
Nodeexception.Verbshould still receive theGet-Verbcorrection:{ Write-Output value { Verb Argument {} } }