Skip to content

Update Hawaii deductions for Act 35 conformity - #9940

Merged
MaxGhenis merged 6 commits into
mainfrom
hi-act-35-2026-conformity
Nov 14, 2026
Merged

MaxGhenis merged 6 commits into
mainfrom
hi-act-35-2026-conformity

Conversation

@MaxGhenis

@MaxGhenis MaxGhenis commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update Hawaii deductions for taxable years beginning after December 31, 2025, under Act 35, SLH 2026 and DOTAX Announcement 2026-06. The limitation, the miscellaneous deduction, the Hawaii-AGI charitable limits and the 2021 non-itemizer amount also change results for years before 2026.

Hawaii retains the section 68 itemized deduction limitation with the 2009 thresholds. Apply $166,800 to every filing status except married filing separately, which uses $83,400, and retain protected deductions when they comprise the whole total. Subtract the smaller of 3% of Hawaii AGI above the threshold and 80% of nonprotected deductions. See the 2025 N-11 worksheet, page 34.

Allow qualified tips from 2026 through 2028, using the federal eligibility and calculation with Hawaii AGI. Exclude dependents' tips and tips received by a filer without an eligible SSN. Reduce the deduction by $100 per complete $1,000 of excess AGI, following Schedule 1-A, lines 11-13.

Add the federal nonitemizer charitable amount to the applicable Hawaii standard deduction, then add the tips deduction for itemizers and nonitemizers. Preserve the dependent-filer standard deduction limit. The 2020 charitable adjustment continues through federal AGI without a second deduction below the line.

Allow miscellaneous expenses through 2025 using main's existing Hawaii conformity parameter. Pool those expenses with miscellaneous claim-of-right repayments before applying the 2% Hawaii-AGI floor, while keeping section 1341 repayments outside that pool.

Compute charitable deductions using Hawaii AGI, the federal donation categories and the shared federal calculation. Apply the category ceilings before the 0.5% floor from 2026, as Congress requires for otherwise allowable contributions in P.L. 119-21, section 70425.

Invariants

  • Itemized deduction reductions remain nonnegative and cannot exceed either the 3% income amount or 80% of nonprotected deductions. Identical inputs produce identical limitations in 2025 and 2026.
  • Protected deductions pass through without reduction. Increasing any deduction cannot lower the allowed amount; increasing Hawaii AGI cannot lower the limitation.
  • Qualified tips deductions stay between zero and eligible tips capped at $25,000, decrease in complete phase-out increments, and vanish for separate filers and outside the conformity years.
  • Charitable deductions stay nonnegative and apply the floor after the contribution ceilings. Federal and Hawaii calculations share the same implementation with different contribution bases.
  • Miscellaneous expenses and miscellaneous repayments share one 2% floor.

Methodology choices

Use Hawaii AGI for the tips phase-out. HRS 235-1 defines AGI through the IRC with Hawaii modifications, and DOTAX uses Hawaii AGI for comparable deduction limits. This remains an inference pending a Hawaii tips worksheet.

Hawaii makes sections 911, 931 and 933 inoperative (signed Act 35, PDF page 11), so Hawaii AGI by law includes the income those sections exclude federally. PolicyEngine's hi_agi starts from federal AGI and doesn't yet add that income, so a filer with such income phases out on a base that omits it. For example, take a single filer with $140,000 of wages, $10,000 of them tips, and $30,000 of section 911 income. The model deducts $10,000, where Hawaii AGI of $170,000 gives $8,000. The gap predates this PR and reaches every rule that reads Hawaii AGI.

Use Hawaii AGI for charitable ceilings and the floor, following the contribution-base treatment in the 2025 N-11 instructions, pages 17-18. Reuse federal contribution categories and current-year deduction calculations; this change adds no carryover tracking.

The 2026 N-11 instructions URLs still returned 404 on November 13, 2026.

Validation

The seven touched YAML files hold 90 cases, and test_hi_itemized_deduction_limitation_properties.py adds five property tests. The cases cover both sides of the first two $1,000 tips steps, a tipped dependent, a spouse without an eligible SSN and each charitable ceiling ahead of the floor. They also cover the pooled 2% floor, each filing status above its limitation threshold, and a dependent filer's standard deduction.

Pull request run 43611581007 at 430d72b440 passed all 36 jobs on GitHub's merge with main 9a63ae6605.

Microsimulation impact

We estimate that this branch lowers hi_income_tax by $4.5m in 2026 on the default dataset, for 144 sampled tax units (80,037 weighted). We compared main at 3386304d28 with this branch at 430d72b440.

Output Main total Change Records changed (weighted)
hi_income_tax $3.15bn -$4.5m 144 (80,037)
hi_itemized_deductions $7.82bn +$45.8m 155 (88,879)
hi_taxable_income $53.37bn -$63.4m 144 (80,037)
state_income_tax $577.2bn -$4.5m 144 (80,037)
income_tax $2,594.9bn $0 0 (0)
household_benefits $2,060.4bn $0 0 (0)
household_net_income $17,199.2bn +$4.5m 137 (75,681)

Main doesn't define hi_tip_income_deduction, so the table leaves it out.

axiom: TheAxiomFoundation/rulespec-us#2219 queued (qualified tips, non-itemizer gifts, the Hawaii-AGI charitable base and floor, and miscellaneous deductions through 2025); TheAxiomFoundation/rulespec-us#1663 queued, extended with a comment on the limitation worksheet; TheAxiomFoundation/rulespec-us#1796 queued for the repayments that share the 2% floor; the pinned corpus lacks Act 35, DOTAX Announcement 2026-06 and the N-11 itemized worksheets, so the signed encoder can't run yet

🤖 Generated with Claude Code

MaxGhenis and others added 5 commits October 6, 2026 16:12
hi_itemized_deductions picked the reduced amount using the federal 2009
personal exemption phase-out thresholds (250,200 joint, 208,500 head of
household, 125,100 separate) instead of Hawaii's 166,800 / 83,400, and
returned 0 when medical, investment interest and casualty deductions
made up the whole total. Replace hi_reduced_itemized_deductions with
hi_itemized_deductions_reduction (worksheet lines 2-10) on Hawaii-owned
parameters for the 3% and 80% rates and the excluded deductions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ions

Act 35, SLH 2026 conforms Hawaii to the Internal Revenue Code as of
December 31, 2025 without making section 224 (qualified tips) or 170(p)
(charitable deduction for non-itemizers) inoperative. Add
hi_tip_income_deduction for 2026-2028, phased out on Hawaii AGI and
denied to separate filers (224(f)), and give Hawaii non-itemizers the
federal 170(p) amount on top of the standard deduction (also restores
the 2020 Act 13 and 2021 Act 89 amounts).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… for charitable limits

Hawaii kept the 2% miscellaneous itemized deductions for 2018-2025
(it never adopted the section 67(g) suspension); Act 35, SLH 2026 ends
them from 2026. Add hi_misc_deduction gated by a Hawaii parameter.

The N-11 instructions state the section 170(b) limits as a share of
Hawaii AGI, and Act 35 conforms to the 0.5% floor from 2026. Move the
federal charitable_deduction formula into a helper that takes the
contribution base, unchanged for the federal deduction, and add
hi_charitable_deduction on Hawaii AGI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s deduction

Checks the reduction against an independent restatement of the Total
Itemized Deductions Worksheet, its bounds, monotonicity, identical 2025
and 2026 results under Act 35, and the tips deduction's bounds and years.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DTrim99

DTrim99 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

PR Review: Update Hawaii income tax for Act 35 (2025 IRC conformity) and fix its itemized deduction limit

Summary

The core of this PR is right, and I checked it against the law first. Act 35, SLH 2026 (H.B. 2329 C.D. 1, effective May 26, 2026, for taxable years beginning after December 31, 2025) does the following:

  • moves HRS 235-2.3(a) to the IRC as of December 31, 2025 (CD1 PDF p. 1);
  • adds section 225 (overtime) to the 235-2.3(b) inoperative list, but not section 224 (tips) (PDF p. 7);
  • makes 163(h)(4) (car loan interest) inoperative (PDF p. 21);
  • strikes the section 67(g) exception (PDF pp. 17-18);
  • keeps section 68 "in the form that it existed as of December 31, 2024; provided that the thresholds shall be those that were operative for federal tax year 2009" (PDF p. 18).

DOTAX Announcement 2026-06 (PDF pp. 2-3) confirms each of those points. It adds that Hawaii conforms to 67(h), to the section 170 non-itemizer deduction and floor, and to section 224.

The Pease fix matches the 2021 and 2025 N-11 Total Itemized Deductions Worksheets line for line: $166,800 ($83,400 separate) for every filing status, the 80%/3% rates, Hawaii AGI, and line 4's "not limited" case. The 2021-2025 miscellaneous deduction and the 2026 non-itemizer charity are also right. On main, joint, head-of-household and surviving-spouse filers between $166,800 and the 2009 personal-exemption thresholds were never limited, and medical-only itemizers got $0. Both bugs are real, and the PR fixes them.

Two of the new Hawaii variables reuse the branch's October 6 copy of a federal formula, and that copy contradicts the statute in claimed years. Main has since fixed both formulas federally (#10192, #10393, #10396). The branch is 765 commits behind main:

  • Five files conflict.
  • On a merged tree, the PR's property test fails.
  • The axiom line points to an issue that covers none of this PR's changes.

Critical (must fix)

C1. hi_tip_income_deduction gets section 224 wrong in 2026-2028 (policyengine_us/variables/gov/states/hi/tax/income/deductions/hi_tip_income_deduction.py:28, 36-38)

The variable copies the merge-base federal formula with Hawaii AGI swapped in. That copy has two errors against 26 U.S.C. 224, which Hawaii adopts from 2026:

  1. The phase-out is continuous. The code reduces by agi_excess * 0.1. Section 224(b)(2)(A) reduces the deduction "by $100 for each $1,000 by which the taxpayer's modified adjusted gross income exceeds $150,000 ($300,000 in the case of a joint return)". So only whole $1,000 steps count; 2025 Schedule 1-A line 11 drops the fraction.
    • I probed a merged tree with a single filer, $10,000 of qualified tips and Hawaii AGI of $150,500. hi_tip_income_deduction gives 9,950. The statute gives 10,000, and main's federal tip_income_deduction gives 10,000 for the same AGI.
    • Every phase-out case in the YAML (200,000, 320,000, 260,000) is a multiple of $1,000, so no test catches this.
  2. Every tax-unit member's tips count, including dependents' (tax_unit.sum(tip_income * occupation_requirement_met)).
    • A dependent's tips are the dependent's own income and go on the dependent's own return. Main's tip_income_deduction_eligible_person (Count only filers' tips and overtime toward the deductions, and require only the recipient's SSN #10396) now excludes them and applies 224(e)(1) per recipient.
    • After a merge, the problem gets worse. Main's tip_income_deduction_ssn_requirement_met now means "any filer is eligible", so this gate would also count tips from a spouse without a valid SSN whenever the other spouse has one.

This is also the "reinvented variable" pattern: the Hawaii copy has already drifted from the federal one it duplicates.

Fix:

  • Build the Hawaii amount from main's federal pieces: tip_income_deduction_eligible_person, and gov.irs.deductions.tip_income.phase_out.increment with np.floor(excess / increment). Gate it on both Hawaii's 2026 conformity flag and gov.irs.deductions.tip_income.in_effect.
  • Better still, factor the federal formula into a helper that takes the MAGI, so the two can't drift.
  • Add cases at Hawaii AGI 150,500 (expect 10,000) and 151,000 (expect 9,900), and one with a tipped dependent (the dependent's tips don't count).

C2. hi_charitable_deduction applies the 2026 floor before the percentage ceilings (policyengine_us/variables/gov/irs/income/taxable_income/deductions/itemizing/_charitable_deduction_helpers.py:60-85; .../itemized/hi_charitable_deduction.yaml:52, Case 5)

26 U.S.C. 170(b)(1)(I), as amended by P.L. 119-21, reads: "Any charitable contribution otherwise allowable (without regard to this subparagraph) as a deduction under this section shall be allowed only to the extent that the aggregate of such contributions exceeds 0.5 percent of the taxpayer's contribution base." Contributions above a ceiling are not "otherwise allowable" this year; they carry over. So the floor comes after the ceilings.

The helper (the merge-base federal formula moved unchanged) subtracts the floor and then caps. Two examples:

  • Case 5 (non-cash $60,000, Hawaii AGI $100,000, 2026) expects 50,000. The statute gives min(60,000, 50% × 100,000) − 0.5% × 100,000 = 49,500.
  • Probe on a merged tree: cash $40,000 at Hawaii AGI $50,000 gives hi_charitable_deduction 30,000. Main's federal charitable_deduction gives 29,750 for the same AGI.

This bites the households the PR is aimed at. A retiree whose pensions and Social Security leave Hawaii AGI small is the one most likely to hit the 50%/60% ceiling.

After a merge the helper is also stale. #10192 rewrote charitable_deduction as compute_charitable_deduction over the resolved_charitable_* inputs, and with the helper kept:

  • Hawaii would ignore charitable_capital_gain_donations* altogether;
  • it would treat cash to non-50% organizations as 50% cash.

No test would fail. So the body's point that "the federal and Hawaii deductions cannot drift apart" holds only if the helper is rebuilt on main's function.

Fix:

  • Delete the helper.
  • Have hi_charitable_deduction call main's compute_charitable_deduction with max_(hi_agi, 0) as the AGI, then apply floor.amount × max_(hi_agi, 0) after the ceilings, as charitable_deduction does. Or refactor charitable_deduction to take the contribution base.
  • Change Case 5 to 49,500 and add a cash-over-ceiling case (cash 40,000, Hawaii AGI 50,000, 2026: 29,750).

Should address

S1. The property test fails on a tree merged with main (policyengine_us/tests/core/test_hi_itemized_deduction_limitation_properties.py:48, OTHER_PERSON = ("mortgage_interest",))

Since #10274 (merged 2026-10-23), hi_interest_deduction adds investment_interest_expense, hi_mortgage_interest_deduction and hi_deductible_mortgage_insurance_premiums. The middle one reads deductible_mortgage_interest, which comes from the home_mortgage_interest inputs. On main, mortgage_interest is a computed sum, and a mortgage_interest input no longer reaches Hawaii's deduction.

  • A merged-tree probe with a mortgage_interest input of 10,000 gives hi_interest_deduction 0. With home_mortgage_interest it gives 10,000.
  • I ran test_limitation_matches_the_worksheet_in_2025_and_2026 on the merged tree. It fails with 2025 total unit 18: 0.0 vs 1.0, and Hypothesis shrinks it to one unit with mortgage_interest: 1.0.

This is a merge blocker that the October 7 CI could not see.

Fix: use home_mortgage_interest in OTHER_PERSON. Its default has no balances, so the deductible share is 1 and the sum invariant holds.

S2. The axiom line doesn't cover this PR's changes

The line cites TheAxiomFoundation/rulespec-us#1521. That issue is OPEN, labelled pe-parity and dispatch-ready, but it encodes only the Form 4684 $100 casualty rule for NY, AL and HI. Its PE side is #9912, and this PR changes no casualty logic.

The extension for this PR's provisions was never posted. Issue #1521 has one comment, about NY medical expenses. Those provisions are:

  • Pease under HRS 235-2.4(b);
  • the 67 miscellaneous deduction through 2025;
  • section 224;
  • section 170(p);
  • the Hawaii-AGI contribution base and floor.

So no open, dispatch-ready issue matches the head. The line also cites a local file and an internal decision id, which don't belong in a public PR body.

Fix:

  • Post the extension, either as a comment on MA excess exemption not applied to long-term capital gains #1521 or as a new pe-parity issue. It needs the module path, the verbatim Act 35 and 235-2.4 text, the required outputs, and companion cases from the N-11 worksheets and the statute (not PolicyEngine output).
  • Rewrite the line to point to it.
  • Remove the local path and the decision id.

S3. References split one PDF into several entries (CLAUDE.md: "One reference entry per source document; URLs that differ only by #page= are one source")

  • .../itemized/misc/in_effect.yaml:15-18: the 2025 N-11 at #page=19 and again at #page=34.
  • .../itemized/sources.yaml:27-30: the 2025 N-11 at #page=17 and again at #page=34.
  • .../itemized/hi_charitable_deduction.py:16-17: n11ins.pdf#page=17 and #page=18 as two tuple entries.
  • .../itemized/hi_itemized_deductions.py:12-14: n11ins.pdf#page=20 and #page=34.

Fix:

  • In the parameters, merge each pair into one entry whose title ends #page 19,34 (quoted).
  • In the variables, keep one href with a # PDF pages 17-18 comment above it.
  • In hi_charitable_deduction.py, cite the announcement for the floor at #page=3, where "imposes a charitable deduction floor" appears. Its p. 2 has only the start of the item.

Sibling #10200 already uses the correct form for the same 2025 N-11 pages.

Suggestions

  1. Stale 2020 note after merging. Take the 2020 charitable deduction for non-itemizers above the line #10186 (merged 2026-10-22) moved the 2020 non-itemizer deduction above the line (charitable_contributions_ald) and set non_itemizers_amount to 0 for 2020. Hawaii now gets it through federal AGI into hi_agi, as Act 13 and the 2020 N-11 (PDF p. 2: "reduces the federal AGI by up to $300") describe. So the comment in non_itemizer_charitable/in_effect.yaml:3-5 ("PolicyEngine applies it to Hawaii non-itemizers below the line") and the body's "2020 non-itemizer charity" note will be wrong after the merge.

    The parameter is also true in every year, so the gate in hi_deductions.py:48 never changes a baseline result. Either start it at 2021 and reword it, or drop it and rely on the federal amounts.

  2. Misc start year and a sibling duplicate. misc/in_effect.yaml starts at 2021, but Hawaii allowed these deductions from 2018 (Act 27, SLH 2018; sources.yaml lists hi_misc_deduction from 2018). Backward extrapolation already makes 2018-2020 true, so this is only about the citation and date.

    Open Model Hawaii's claim of right deduction and credit (section 1341 as operative in Hawaii from 2022) #10200 adds itemized/miscellaneous_deductions_allowed.yaml with the same 2018-2025 true / 2026 false content and also edits sources.yaml. Whichever lands second should reuse the other's parameter.

  3. Tips phase-out on Hawaii AGI. This is a reasonable gap-fill that follows DOTAX's practice for every other AGI-based limit. Two notes:

    • Hawaii makes subchapter N inoperative (235-2.3(b)(39) as renumbered), so sections 911/931/933 never reduce Hawaii AGI and no add-back is needed. A one-line comment would say so.
    • The TY2026 N-11 instructions still return 404 (checked 2026-11-05). Revisit when they're published.
  4. Align the new hi_deductions.yaml cases after merging. Cases 7-14 set head_is_dependent_elsewhere: false. Main's hi_deductions now reads head_or_spouse_is_dependent_elsewhere, and main's cases use claimed_as_dependent_on_another_return. The input is harmless, but it no longer controls anything.

  5. PR body housekeeping. Remove the local filesystem paths: the TY2025 write-up, the fails-on-main output, the locked-run script and log, examples.py and charity_tests.txt. Also remove the decision id. Attach or summarize the content instead.

  6. Merge resolution of hi_deductions.py. Keep main's reference tuple, not the branch's documentation URL block, which main's Catch reference keys policyengine-core drops and citation URLs filed in documentation #9849 guard rejects. Add the non-itemizer amount to main's applicable_standard_deduction, so dependent filers keep the HRS 235-2.4(a)(3) limit.

Verified correct

  • Pease (all years, including 2026).
    • Act 35 keeps section 68 as of December 31, 2024 with the 2009 thresholds (CD1 PDF p. 18). The 2009 Schedule A worksheet line 6 reads "$166,800 ($83,400) if married filing separately" (PDF p. 11).
    • The 2021 (PDF p. 32) and 2025 (PDF p. 34) N-11 worksheets use Hawaii AGI (line 6), 80% (line 5), 3% (line 9), and exclude medical, investment interest and casualty losses (lines 2a-2c).
    • Line 4 "No. Your deduction is not limited" is now honoured.
    • The 2/37 rule doesn't reach Hawaii.
  • hi_reduced_itemized_deductions removal. It has no callers on main outside Hawaii's own variable and tests.
  • Miscellaneous deduction. For 2021-2025, the 2025 N-11 line 21f (PDF p. 19) says Hawaii did not adopt the 2018-2025 suspension. Worksheet A-6 (PDF p. 34) uses 2% of Hawaii AGI, "If zero or less, enter zero". For 2026, Act 35 strikes the exception (PDF pp. 17-18), and DOTAX confirms 67(h) disallows the deduction.
  • Tips gating. The 2025 flag is false because the 2025 code is the IRC as of December 31, 2024 (the bracketed "[2024,]" in 235-2.3(a)). From 2026, section 224 is not in 235-2.3(b), DOTAX confirms conformity (Ann. 2026-06 PDF p. 3), and 224(h) ends the deduction after 2028. The deduction is added on top of either the standard or itemized amount, per 63(b)/(d). The 224(f) separate-filer denial is right.
  • 2026 guard case. Hawaii excludes the senior deduction (151 inoperative), overtime (225 inoperative) and car loan interest (163(h)(4) inoperative) in 2026.
  • Non-itemizer charity. The 2021 N-11 line 23 (PDF p. 20) gives $300/$600, and DOTAX confirms conformity from 2026.
  • Charitable limits. These are shares of Hawaii AGI (2025 N-11 PDF pp. 17-18), and the negative-AGI clamp is pinned by Case 6.
  • Tests.
    • The YAML is in variable-named files.
    • Every new term and list entry is pinned: the excluded-deduction entries (reduction Case 3), the agi_excess clamp (reduction Cases 2 and 7), the misc clamps (Cases 3-4), the tips gates (Cases 2, 3, 7-9), and the deduction terms (hi_deductions Cases 7-14).
    • Property tests in tests/core are established practice, and the body labels its timing as local, not Linux CI.
  • Code patterns. No new state-gated int or enum key, so the NH Add New Hampshire state supplementation for 2026 #10156 pattern doesn't apply. Everything is vectorized, with period-level if only on parameters. Entities and periods are correct.
  • Changelog. changelog.d/hi-act-35-2026-conformity.fixed.md is top-level, and the type fits.
  • Partner tests. No file under tests/policy/baseline/partners/ changes.

Hand checks (head formulas):

  1. hi_itemized_deductions Case 4, joint 2026, AGI 200,000, total 30,000. Line 5: 30,000 × 0.8 = 24,000. Line 9: (200,000 − 166,800) × 0.03 = 996. 30,000 − 996 = 29,004.
  2. Case 7, separate, AGI 100,000: (100,000 − 83,400) × 0.03 = 498, and 30,000 − 498 = 29,502.
  3. Case 10, medical 45,000 of 50,000, AGI 1,000,000. Line 5: 5,000 × 0.8 = 4,000. Line 9: 833,200 × 0.03 = 24,996. 50,000 − 4,000 = 46,000.
  4. Case 13, joint, AGI 1,000,000, total 30,000: min(24,000, 24,996) = 24,000, so 6,000.
  5. hi_itemized_deductions_reduction Case 1, separate, AGI 200,000, total 10,000, excluded 300 + 400 + 2 × 100 = 900. Line 5: 9,100 × 0.8 = 7,280. Line 9: 116,600 × 0.03 = 3,498, the smaller.
  6. Reduction Case 3, joint, AGI 166,880, total = excluded = 900: limited 0, so 0. Dropping any excluded entry would give min(0.8 × 200 to 400, 80 × 0.03 = 2.4) = 2.4, so each entry is pinned.
  7. hi_tip_income_deduction Case 6, joint, Hawaii AGI 320,000: 20 × $100 = 2,000, and 10,000 − 2,000 = 8,000. Case 10, head of household, 260,000: 110 × $100 = 11,000 > 10,000, so 0. Both are right under step or continuous rules.
  8. hi_charitable_deduction Case 1, 2026, cash 20,000, Hawaii AGI 50,000: the ceiling of 30,000 doesn't bind, and 20,000 − 250 = 19,750. Case 4: allowable 1,300 − floor 500 = 800, with the floor taking non-cash (A) before cash (G) per 170(b)(1)(I). Case 5 is wrong (see C2).
  9. hi_misc_deduction Case 1: 5,500 − 2% × 50,000 = 4,500. Case 4: Hawaii AGI −20,000 makes the floor 0, so 800. Case 5: 4,000 − 2,000 = 2,000.
  10. hi_deductions Case 7: 8,000 + min(1,000, 1,500) = 9,000. Case 10 (2021): 2,200 + min(300, 500) = 2,500. Case 12: max(8,500, 9,000) = 9,000.
  11. hi_taxable_income Case 3: 40,000 − (8,000 + 8,000) − 1,144 = 22,856. Case 5 (age 70): 50,000 − 8,000 − 2 × 1,144 = 39,712.

Axiom line assessment

The line is not valid for this head (S2). #1521 is OPEN, pe-parity and dispatch-ready, but only for casualty losses under 235-2.4(l)/(k), which is #9912's change. No public issue or comment covers:

  • Pease (235-2.4(b));
  • section 67 through 2025;
  • section 224;
  • section 170(p);
  • the Hawaii-AGI contribution base.

Related open issues (#1663 for wagering losses in the same worksheet, #1556 for mortgage limits) don't cover them either.

CI status

35/35 checks pass, all completed by 2026-10-07. That run predates main's source-conflict ratchet (#10287), #9558, #10317, #10408, #10186, #10192, #10274 and the federal tips fixes, so a fresh run after merging main is needed.

Branch status

Verdict: REQUEST_CHANGES

DTrim99
DTrim99 previously requested changes Nov 5, 2026

@DTrim99 DTrim99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes: 2 critical ((1) hi_tip_income_deduction copies the old federal formula, with a continuous phase-out instead of § 224(b)(2)'s $100 per full $1,000, and it counts dependents' tips; rebuild on main's federal pieces; (2) hi_charitable_deduction applies the 2026 0.5% floor before the ceilings, while § 170(b)(1)(I) applies it to contributions otherwise allowable: Case 5 should be 49,500, not 50,000), 3 should (the property test fails on the merged tree since #10274; the axiom line's #1521 covers only casualty losses, and it cites a local path; split PDF references). 765 behind main with 5 conflicts. Full report in the comment above.

Use shared federal calculations for qualified tips and charitable donations.
Preserve Hawaii's dependent deduction limit and pool miscellaneous expenses with repayments under one floor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

David, here's where each item of your review stands at 430d72b440, which merges main at 3386304d28 and carries every fix:

The merge resolves the five conflicts you listed, and the branch still merges cleanly with main. An independent AI review approved 430d72b440.

🤖 Generated with Claude Code

@MaxGhenis
MaxGhenis dismissed DTrim99’s stale review November 14, 2026 17:36

Commit 430d72b merges main and answers each item of this review. My reply above maps each item to its file and line.

@MaxGhenis
MaxGhenis merged commit 5d791e7 into main Nov 14, 2026
148 of 153 checks passed
@MaxGhenis

Copy link
Copy Markdown
Contributor Author

US + core hub merge audit, us#9940 at 430d72b440ca1db1db3925b769340278bf1ec960 (squash): Update Hawaii deductions for Act 35 conformity.

  • Reviews:
    • DTrim99 requested changes at ebc2285615. The tips deduction copied an old federal formula, with a continuous phase-out that also counted dependents' tips, and the charitable deduction took the 2026 floor before the ceilings. Three should-address items covered the property test, the axiom: line and split PDF references, and six suggestions followed.
    • 430d72b440 merges main at 3386304d28 and answers each item. It moves the federal tips formula into a helper that takes the modified AGI, and it rebuilds the Hawaii charitable deduction on main's federal calculation with Hawaii AGI as the contribution base. It also fixes the property test input and the references, and it reuses main's parameters for the 2020 gifts and the miscellaneous deduction.
    • An independent review approved 430d72b440 with no blocking finding. It read the signed Act 35, DOTAX Announcement 2026-06, the 2021 and 2025 N-11 instructions, and IRC 63, 67, 68, 170 and 224, with section 68 in its 2024 edition. It mapped each of DTrim99's items to the file and line that answers it.
    • On a tree of the head it ran the eight changed test files, one process each: 95 passed and none failed. It computed five households by hand from the head's parameters, then matched each to a script run on the head and on the merge base.
    • The review listed corrections to the description, and I made each before merge. The axiom: line now names a new pe-parity issue and two queued ones, and the impact section holds the measured results. The validation section gives the test counts, and the methodology section says that hi_agi omits income excluded under sections 911, 931 and 933.
    • I dismissed DTrim99's change request with a reply that maps each item to its file and line.
  • Methodology choices for maintainers:
    • The tips deduction phases out on Hawaii AGI, which HRS 235-1 defines through the Code with Hawaii's changes. DOTAX hadn't published the 2026 N-11 instructions on November 13, 2026. For example, a single filer with $10,000 of tips, federal AGI of $250,000 and Hawaii AGI of $200,000 deducts $5,000; federal AGI would leave nothing.
    • Hawaii makes sections 911, 931 and 933 inoperative, so Hawaii AGI by law includes the income they exclude federally. hi_agi starts from federal AGI and doesn't add that income. A single filer with $140,000 of wages, $10,000 of them tips, and $30,000 of section 911 income deducts $10,000, where Hawaii AGI of $170,000 gives $8,000. The gap predates this PR.
    • The charitable ceilings and the 2026 floor use positive Hawaii AGI as the contribution base, and the model tracks no carryovers. For example, a single filer aged 67 with $60,000 of wages, an $80,000 taxable pension that Hawaii subtracts and $40,000 of cash gifts deducts min(40,000, 60% x 60,000) - 0.5% x 60,000 = $35,700 in 2026. On federal AGI, the merge base gave $39,300.
  • Gates checked live at merge:
    • gh pr checks exits 0;
    • the latest Pull request run at the head, 43611581007, passed and tested this head merged into main at 9a63ae6605;
    • MERGEABLE;
    • not a draft;
    • no reviewer's latest review requests changes;
    • the semantic-overlap guard: since 9a63ae6605, main has changed no area this PR touches. Between the PR's merge base 3386304d28 and main at 3ab9b19a11, main changed 640 files and none of this PR's 26. Its Hawaii changes touch six LIHEAP files and the 13 files of Add Hawaii's employee temporary disability insurance contribution #10677's temporary disability insurance contribution. On the merged tree no file reads the deleted hi_reduced_itemized_deductions, and California's import of compute_charitable_deduction still resolves. The branch merges into main at 3ab9b19a11 without conflict;
    • the merge pins the head.
  • Impact: we estimate that the change lowers Hawaii income tax by $4.5m in 2026 on the default dataset, for 144 sampled tax units (80,037 weighted). Hawaii itemized deductions rise $45.8m and Hawaii taxable income falls $63.4m. Federal income tax and household benefits don't move, and household net income rises $4.5m. The run compared main 3386304d28 with 430d72b440.
  • Next:
    • After this squash, Count gambling winnings in federal gross income and fix the wagering losses deduction #10070, the wagering-losses PR behind Encode Hawaii wagering losses and protect them in the total itemized deduction worksheet TheAxiomFoundation/rulespec-us#1663, conflicts in itemized/sources.yaml and hi_itemized_deductions.yaml. It also edits hi_reduced_itemized_deductions.py and its YAML, which this PR deletes. It should add wagering losses to limitation/excluded_deductions.yaml when it merges main.
    • hi_agi should add the income that sections 911, 931 and 933 exclude, through hi_additions, so every rule that reads Hawaii AGI picks it up. The comment at hi_tip_income_deduction.py:25-27 then holds in the model, and the example filer's deduction falls from $10,000 to $8,000.
    • Three comments in hi_tip_income_deduction.yaml (lines 61, 74 and 124) still state the phase-out as 10% of the excess. Each expected value holds, since each excess holds whole thousands, and a follow-up can restate them as whole $1,000 steps.
    • From 2026, sections 67(b)(13) and 67(g) let itemizers deduct educator expenses outside the 2% floor, and Hawaii conforms through Act 35. Neither the federal nor the Hawaii model covers it.
    • When DOTAX publishes the 2026 N-11 instructions, someone should check the tips worksheet's income base against the Hawaii AGI reading.
  • Axiom: TheAxiomFoundation/rulespec-us#2219 queues Hawaii's qualified tips deduction, non-itemizer gifts, the Hawaii-AGI charitable base and floor, and miscellaneous deductions through 2025. TheAxiomFoundation/rulespec-us#1663 stays queued, and a comment there adds the limitation rows for every filing status. TheAxiomFoundation/rulespec-us#1796 stays queued for the repayments that share the 2% floor. The signed encoder can't run yet, since the corpus holds no copy of Act 35 or the announcement and the pinned release lacks the N-11 worksheet pages.

🤖 Generated with Claude Code

@MaxGhenis
MaxGhenis deleted the hi-act-35-2026-conformity branch November 14, 2026 17:37
MaxGhenis added a commit that referenced this pull request Nov 14, 2026
Both sides split the federal charitable deduction formula. Keep
charitable_deduction_given_contribution_base from #9940, which Hawaii
calls with its own adjusted gross income, and split the ceilings out of
it as charitable_deduction_before_floor_given_contribution_base, which
charitable_deduction_before_floor now calls with federal positive AGI.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
MaxGhenis added a commit that referenced this pull request Nov 14, 2026
#9940 on main replaced hi_reduced_itemized_deductions with
hi_itemized_deductions_reduction and a list of the deductions Hawaii's
limitation leaves out. Take main's deletion and add
wagering_losses_deduction to that list: filers enter gambling losses on
line 2d of the Total Itemized Deductions Worksheet. Move this branch's
Hawaii cases to main's test files with the same expected deductions.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants