Skip to content

Fix Vaal Caress Onslaught for gloves and Reliquarian #10422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcagnion wants to merge 4 commits into
base: dev
Choose a base branch
from
+32 −4
Open

Fix Vaal Caress Onslaught for gloves and Reliquarian #10422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86d6cd5
Support Onslaught after using a Vaal skill
mcagnion Nov 8, 2026
9ef0384
Reuse existing Vaal Recently configuration for Onslaught
mcagnion Nov 8, 2026
197a206
Recognize Vaal Caress Onslaught across buff durations
mcagnion Nov 9, 2026
6b5acf6
Simplify Vaal Caress Onslaught regression tests
mcagnion Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions spec/System/TestVaalCaress_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
describe("Vaal Caress Onslaught", function()
for _, duration in ipairs({ 5, 10, 20 }) do
it("activates the " .. duration .. "-second modifier after recent Vaal skill use", function()
newBuild()
build.skillsTab:PasteSocketGroup("Fireball 1/0 1\n")
build.mainSocketGroup = 1
runCallback("OnFrame")
assert.are.equal("Fireball", build.calcsTab.mainEnv.player.mainSkill.activeEffect.grantedEffect.name)
local inactiveSpeed = build.calcsTab.mainOutput.Speed
local inactiveMovement = build.calcsTab.mainOutput.MovementSpeedMod
build.configTab.input.customMods = "You gain Onslaught for " .. duration .. " seconds on using a Vaal Skill"

local function check(input, multiplier)
build.configTab.input.conditionUsedVaalSkillRecently = input.conditionUsedVaalSkillRecently
build.configTab.input.buffOnslaught = input.buffOnslaught
build.configTab:BuildModList()
runCallback("OnFrame")
assert.are.near(inactiveSpeed * multiplier, build.calcsTab.mainOutput.Speed, 1e-9)
assert.are.near(inactiveMovement + multiplier - 1, build.calcsTab.mainOutput.MovementSpeedMod, 1e-9)
end

check({}, 1)
check({ conditionUsedVaalSkillRecently = true }, 1.2)
check({ conditionUsedVaalSkillRecently = true, buffOnslaught = true }, 1.2)
check({ buffOnslaught = true }, 1.2)
check({}, 1)
end)
end
end)
6 changes: 2 additions & 4 deletions src/Data/ModCache.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22850,8 +22850,7 @@ c["You gain Onslaught for 2 seconds on Killing Taunted Enemies"]={{[1]={[1]={typ
c["You gain Onslaught for 2 seconds per Endurance Charge when Hit"]={{[1]={[1]={type="Multiplier",var="EnduranceCharge"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit "}
c["You gain Onslaught for 2 seconds per Endurance Charge when Hit You gain Onslaught for 5 seconds per Endurance Charge when Hit"]={{[1]={[1]={type="Multiplier",var="EnduranceCharge"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit You gain for 5 seconds per Endurance Charge when Hit "}
c["You gain Onslaught for 2 seconds when Hit"]={{[1]={flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit "}
c["You gain Onslaught for 20 seconds on using a Vaal Skill"]={{[1]={flags=0,keywordFlags=512,name="Condition:Onslaught",type="FLAG",value=true}}," on using a "}
c["You gain Onslaught for 20 seconds on using a Vaal Skill +2 to Level of all Vaal Skill Gems"]={{[1]={flags=0,keywordFlags=512,name="Condition:Onslaught",type="FLAG",value=true}}," on using a +2 to Level of all Vaal Skill Gems "}
c["You gain Onslaught for 20 seconds on using a Vaal Skill"]={{[1]={[1]={type="Condition",var="UsedVaalSkillRecently"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}},nil}
c["You gain Onslaught for 3 seconds on Culling Strike"]={{[1]={flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," on Culling Strike "}
c["You gain Onslaught for 3 seconds on Culling Strike 100% chance to Avoid being Chilled during Onslaught"]={{[1]={[1]={type="Condition",var="Onslaught"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," on Culling Strike 100% chance "}
c["You gain Onslaught for 3 seconds on Kill"]={{[1]={[1]={type="Condition",var="KilledRecently"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}},nil}
Expand All @@ -22861,8 +22860,7 @@ c["You gain Onslaught for 4 seconds on Hit"]={{[1]={flags=4,keywordFlags=0,name=
c["You gain Onslaught for 4 seconds on Kill"]={{[1]={[1]={type="Condition",var="KilledRecently"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}},nil}
c["You gain Onslaught for 4 seconds on Kill while affected by Haste"]={{[1]={[1]={type="Condition",var="KilledRecently"},[2]={type="Condition",var="AffectedByHaste"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}},nil}
c["You gain Onslaught for 4 seconds when Hit"]={{[1]={flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit "}
c["You gain Onslaught for 5 seconds on using a Vaal Skill"]={{[1]={flags=0,keywordFlags=512,name="Condition:Onslaught",type="FLAG",value=true}}," on using a "}
c["You gain Onslaught for 5 seconds on using a Vaal Skill You gain Onslaught for 20 seconds on using a Vaal Skill"]={{[1]={flags=0,keywordFlags=512,name="Condition:Onslaught",type="FLAG",value=true}}," on using a You gain on using a Vaal Skill "}
c["You gain Onslaught for 5 seconds on using a Vaal Skill"]={{[1]={[1]={type="Condition",var="UsedVaalSkillRecently"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}},nil}
c["You gain Onslaught for 5 seconds per Endurance Charge when Hit"]={{[1]={[1]={type="Multiplier",var="EnduranceCharge"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit "}
c["You gain Onslaught for 5 seconds per Endurance Charge when Hit 100% increased Effect of Onslaught on you"]={{[1]={[1]={type="Multiplier",var="EnduranceCharge"},flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit 100% increased "}
c["You gain Onslaught for 6 seconds when Hit"]={{[1]={flags=0,keywordFlags=0,name="Condition:Onslaught",type="FLAG",value=true}}," when Hit "}
Expand Down
1 change: 1 addition & 0 deletions src/Modules/ModParser.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4026,6 +4026,7 @@ local specialModList = {
-- Buffs/debuffs
["phasing"] = { flag("Condition:Phasing") },
["onslaught"] = { flag("Condition:Onslaught") },
["you gain onslaught for %d+ seconds on using a vaal skill"] = { flag("Condition:Onslaught", { type = "Condition", var = "UsedVaalSkillRecently" }) },
["rampage"] = { flag("Condition:Rampage") },
["soul eater"] = { flag("Condition:CanHaveSoulEater") },
["unholy might"] = { flag("Condition:UnholyMight"), flag("Condition:CanWither"), },
Expand Down
Loading