Repository navigation
Conversation
Recognize the current and legacy Vaal Caress modifiers for gloves and Reliquarian. Reuse global Onslaught with distinct five- and twenty-second conditions so ordinary skills and movement receive the buff beyond Recently.
Keep the Vaal Caress fix on the existing Recently condition without adding duration-specific settings. The existing manual Onslaught option represents states beyond Recently while the five- or twenty-second buff remains active.
mcagnion
changed the title
mcagnion
marked this pull request as ready for review
November 9, 2026 19:20
Replace duplicate duration literals with one full-line pattern and cover the ten-second Ruthless Reliquarian modifier with the existing cast-speed test. Keep the shared Onslaught calculation and Recently configuration unchanged.
Exercise the modifier durations in a minimal Fireball build instead of reconstructing equipment and passive trees. Keep activation, deactivation and overlapping manual Onslaught checks on the calculated results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration
With Vaal Caress equipped or Reliquarian's Vaal Caress notable allocated, enable the existing Have you used a Vaal Skill Recently? option. A main Vaal skill activates it automatically.
Recently covers four seconds. For the remaining buff duration (five seconds for legacy gloves, twenty for current gloves and standard Reliquarian, ten for Ruthless Reliquarian), use Do you have Onslaught? instead.
Description of the problem being solved:
The modifier was partly parsed as Vaal-specific Onslaught, so ordinary skills and movement missed the buff. Parse the complete modifier independently of its duration and activate the existing Onslaught buff through the Vaal Recently condition.
Steps taken to verify a working solution:
Before and after screenshots:
Vaal Caress modifier recognition
Current gloves with an ordinary Fireball
Same SweetAndVicious export on the base and fixed versions: current gloves, ordinary Fireball, Recently enabled, manual Onslaught off.
Calculation breakdown