Repository navigation
Web hex view: stale answers change nothing, no dump hides the panel (1.43.1) - #94
Merged
Merged
Conversation
…panel An answer that comes after a newer request no longer sets the dump size or goes back to address 0 (Go could then refuse a valid address). A state with no dump, after the service started again, hides the panel and drops a part still coming, instead of keeping the old bytes.
PR Summary by QodoPrevent stale hex responses and clear the panel when no dump exists
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the two minor findings left from #88 (answered there).
hexLoad()now checks the request number before it touches any state. An answer to an older request no longer setshx.sizeor resetshx.offon a 416, and draws nothing. Before, such an answer could make Go refuse a valid address once.render()hides the panel when the state has nofileand nothing is running. The server setsfileempty only on a fresh start.hexClose()also drops a part still coming (hx.req++), so an open page no longer keeps the old dump's bytes.Checked in Docker:
LIBUSB=1and musl x86_64/arm/mipsel/mips build with 0 warnings.