Skip to content

Android: -PmicrosnanderAbis must name known ABIs (1.43.2) - #93

Merged
compot-dev merged 3 commits into
mainfrom
android-abi-check-92
Nov 16, 2026
Merged

compot-dev merged 3 commits into
mainfrom
android-abi-check-92

Conversation

@compot-dev

@compot-dev compot-dev commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #92.

-PmicrosnanderAbis must be a non-empty list of known ABIs (arm64-v8a, armeabi-v7a, x86_64, x86); otherwise the build stops at configuration with that list. Empty entries (arm64-v8a,,armeabi-v7a, a trailing comma) are errors too. Before, an empty value left abiFilters empty, which packs every ABI of the NDK, and a typo went unnoticed. The default arm64-v8a,armeabi-v7a is unchanged. Same check as OpenIPC/vtesse#84.

Version 1.43.2 (rebased on main after #91 and #94), CHANGELOG.md.

Checked locally in Docker (compot/android: NDK r27c, Gradle 8.11.1):

  • '', ,, arm64, arm64-v8a,,armeabi-v7a, arm64-v8a, stop the build with the list; arm64-v8a and arm64-v8a, x86_64 configure.
  • assembleDebug lintDebug assembleRelease (as in CI): passes; the release APK (177 KB, unsigned) carries lib/arm64-v8a and lib/armeabi-v7a only.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Reject empty or unsupported Android ABI selections

🐞 Bug fix 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Reject empty or unknown Android ABI selections during configuration, preventing unintended APK
 contents.
• Preserve the default ARM ABIs and document the fix in version 1.42.2.
Diagram

graph TD
  P["ABI property or default"] --> N["Parse ABI list"] --> V{"Nonempty and known?"} -->|yes| F["NDK ABI filters"] --> A["Android APK"]
  V -->|no| E["Configuration error"]
Loading
High-Level Assessment

Validate at the Gradle property boundary, before setting abiFilters. This directly prevents an empty filter set from packaging every NDK ABI and gives immediate feedback for typos; relying on downstream build behavior would not address both cases.

Files changed (3) +15 / -4

Bug fix (1) +8 / -3
build.gradle.ktsValidate requested ABIs before configuring NDK filters +8/-3

Validate requested ABIs before configuring NDK filters

• Parses the ABI property, requires at least one supported ABI, and reports the allowed names on failure. Valid selections populate abiFilters; the default remains arm64-v8a and armeabi-v7a.

android/app/build.gradle.kts

Documentation (1) +6 / -0
CHANGELOG.mdDocument the Android ABI validation fix +6/-0

Document the Android ABI validation fix

• Adds the 1.42.2 entry describing rejected empty or unknown ABI selections and the unchanged ARM default.

CHANGELOG.md

Other (1) +1 / -1
main.cSet the release version to 1.42.2 +1/-1

Set the release version to 1.42.2

• Bumps _VER, which also supplies the Android app version through its Gradle configuration.

src/main.c

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Empty ABI entries are silently accepted ✓ Resolved
Description
The abis pipeline in android/app/build.gradle.kts filters out empty entries before require
validates them against knownAbis. A leading, repeated, or trailing comma in a non-empty
microsnanderAbis value therefore goes unreported and the remaining ABIs reach the APK filters,
while an all-empty value already fails validation.

Grey Divider

Tip of the day
💡 Did you know, you can choose which labels appear on a finding, and whether they show icons or text

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

An empty -PmicrosnanderAbis= left abiFilters empty, which packs every ABI of the NDK into
the APK; a typo (-PmicrosnanderAbis=arm64) was not caught either. Both now stop the build
with the list of the ABIs the native build supports.
@compot-dev compot-dev changed the title Android: -PmicrosnanderAbis must name known ABIs (1.42.2) Android: -PmicrosnanderAbis must name known ABIs (1.43.2) Nov 16, 2026
@compot-dev

Copy link
Copy Markdown
Collaborator Author

Empty ABI entries are silently accepted: fixed in b07a335. Empty entries are no longer dropped before the check, so arm64-v8a,,armeabi-v7a and arm64-v8a, stop the build with the ABI list. Checked in Docker together with '', ,, arm64 (rejected) and arm64-v8a, arm64-v8a, x86_64 (accepted); assembleDebug lintDebug assembleRelease passes, APKs ARM only. Also rebased on main (#91, #94): version 1.43.2.

@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 3c1c6cb

@compot-dev
compot-dev merged commit 9fb9e6d into main Nov 16, 2026
9 checks passed
@compot-dev
compot-dev deleted the android-abi-check-92 branch November 16, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: -PmicrosnanderAbis must name known ABIs

1 participant