Repository navigation
Android: -PmicrosnanderAbis must name known ABIs (1.43.2) - #93
Conversation
PR Summary by QodoReject empty or unsupported Android ABI selections
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
An empty -PmicrosnanderAbis= left abiFilters empty, which packs every ABI of the NDK into the APK; a typo (-PmicrosnanderAbis=arm64) was not caught either. Both now stop the build with the list of the ABIs the native build supports.
45b9d48 to
3c1c6cb
Compare
|
Empty ABI entries are silently accepted: fixed in b07a335. Empty entries are no longer dropped before the check, so |
|
/review |
|
Code review by qodo was updated up to the latest commit 3c1c6cb |
Closes #92.
-PmicrosnanderAbismust be a non-empty list of known ABIs (arm64-v8a, armeabi-v7a, x86_64, x86); otherwise the build stops at configuration with that list. Empty entries (arm64-v8a,,armeabi-v7a, a trailing comma) are errors too. Before, an empty value leftabiFiltersempty, which packs every ABI of the NDK, and a typo went unnoticed. The defaultarm64-v8a,armeabi-v7ais unchanged. Same check as OpenIPC/vtesse#84.Version 1.43.2 (rebased on main after #91 and #94),
CHANGELOG.md.Checked locally in Docker (compot/android: NDK r27c, Gradle 8.11.1):
'',,,arm64,arm64-v8a,,armeabi-v7a,arm64-v8a,stop the build with the list;arm64-v8aandarm64-v8a, x86_64configure.assembleDebug lintDebug assembleRelease(as in CI): passes; the release APK (177 KB, unsigned) carrieslib/arm64-v8aandlib/armeabi-v7aonly.