Repository navigation
Android app: hex view of the last dump (#85) - #91
Conversation
Under the status registers: address, bytes and ASCII, 16 bytes a row, 512 bytes a page, 00 and FF dim; Prev, Next and Go to an address in hex (up to 12 digits, inside the dump). Only the page shown is read from the file; the panel follows the newest dump and goes when there is none. Part of #85.
PR Summary by QodoAdd a paged hex view for the latest Android dump
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
1.
|
…om its start, nothing while busy The address field has its own row and Prev, Go and Next share the next one, so a phone in portrait shows them all. A dump is known by its name, time and length: a self-test block written again under the same name opens at its start. While an operation runs the hex controls are off, as Save as and Share, since it may be writing the dump shown.
|
All three findings are fixed in 8af54fd:
|
|
/review |
|
Code review by qodo was updated up to the latest commit 8af54fd |
# Conflicts: # CHANGELOG.md # src/main.c
|
/review |
|
Code review by qodo was updated up to the latest commit 38a6f5d |
Part of #85. This is the hex view on Android, the same view as the web mode has since 1.42.0.
dumpsdirectory, which is the same file Save as and Share use. A self-test block counts as a dump too.RandomAccessFilereads only the 512 bytes shown. The panel resets to address 0 for a new dump and hides when there is no dump.colors.xmlonly (amber, ink, dim), and the field and table use the existingdisplaydrawable. Nothing new is added to the brass palette.Tests:
assembleDebugbuilds, andlintDebugreports no issues.LIBUSB=1and musl x86_64/arm/mipsel/mips build with 0 warnings, and the tests pass. There is no C change besides the version.odof the file shows);4D 58 50 54 01 01 00 FF …withMXPT,ROMandKEY_CUSTin the ASCII, the same asod;