Skip to content

Android: arm64-v8a and armeabi-v7a by default, x86_64 only on request (1.42.1) - #90

Merged
compot-dev merged 2 commits into
mainfrom
android-abis-89
Nov 15, 2026
Merged

compot-dev merged 2 commits into
mainfrom
android-abis-89

Conversation

@compot-dev

@compot-dev compot-dev commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #89.

  • android/app/build.gradle.kts: the default ABI list is arm64-v8a,armeabi-v7a, as in camex, vectis and vtesse; x86_64 is no longer in the APK. An x86_64 emulator build: -PmicrosnanderAbis=arm64-v8a,armeabi-v7a,x86_64.
  • Version 1.42.1 (after Web mode: hex view of the last dump (#85) #88's 1.42.0), CHANGELOG.md.

Checked locally in Docker (compot/android, NDK r27c, Gradle 8.11.1), on main with #88:

  • assembleDebug lintDebug assembleRelease: lint clean; both APKs carry lib/arm64-v8a and lib/armeabi-v7a only. Release APK (unsigned) 172 KB, with x86_64 242 KB.
  • assembleRelease -PmicrosnanderAbis=arm64-v8a,armeabi-v7a,x86_64: lib/x86_64 is there too.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Default Android APKs to ARM ABIs with optional x86_64

⚙️ Configuration changes 📝 Documentation 🕐 Less than 10 minutes

Grey Divider

AI Description

• Default Android APKs include arm64-v8a and armeabi-v7a, reducing package size for phones and TV
 boxes.
• Keep x86_64 available through an explicit Gradle property for emulator builds.
• Bump the version to 1.41.2 and document the ABI change.
Diagram

graph TD
  D["ARM defaults"] --> G["Gradle configuration"] --> C["CMake native build"] --> P["Packaged APK"]
  O["ABI override"] --> G
  V["Version source"] --> G
Loading
High-Level Assessment

Keep the existing ABI filter and change its default. This preserves the explicit override for emulator builds without introducing separate build variants or changing native build wiring.

Files changed (3) +11 / -5

Documentation (1) +6 / -0
CHANGELOG.mdDocument the 1.41.2 Android ABI change +6/-0

Document the 1.41.2 Android ABI change

• Adds a 1.41.2 entry explaining the ARM-only default, smaller APK, and property for including x86_64.

CHANGELOG.md

Other (2) +5 / -5
build.gradle.ktsDefault native packaging to two ARM ABIs +4/-4

Default native packaging to two ARM ABIs

• Removes x86_64 from the default ABI filters while retaining the microsnanderAbis override. Updates comments to reflect the default and emulator option.

android/app/build.gradle.kts

main.cSet the version to 1.41.2 +1/-1

Set the version to 1.41.2

• Bumps the shared version constant, which Gradle also reads for Android version metadata.

src/main.c

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Previous reviews

Review updated until commit 633b5d3 ⚖️ Balanced

Results up to commit 3f8335b


🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

…#89)

Phones and TV boxes are ARM, and x86_64 emulator images of Android 11 and
later run ARM libraries themselves. -PmicrosnanderAbis=...,x86_64 still builds
for an x86_64 emulator.
@compot-dev compot-dev changed the title Android: arm64-v8a and armeabi-v7a by default, x86_64 only on request (1.41.2) Android: arm64-v8a and armeabi-v7a by default, x86_64 only on request (1.42.1) Nov 15, 2026
@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 633b5d3

@compot-dev
compot-dev merged commit 715a516 into main Nov 15, 2026
9 checks passed
@compot-dev
compot-dev deleted the android-abis-89 branch November 15, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: arm64-v8a and armeabi-v7a by default, x86_64 only on request

1 participant