Repository navigation
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Oct 21, 2026
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
2 times, most recently
from
October 21, 2026 19:33
42adc41 to
f9aa1bf
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
2 times, most recently
from
October 22, 2026 04:15
a4c1fe7 to
697e3bd
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
from
October 22, 2026 04:26
697e3bd to
7856417
Compare
Contributor
Author
|
/ok to test 7856417 |
Contributor
|
mdboom
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
from
October 23, 2026 15:04
7856417 to
b01e4ad
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
2 times, most recently
from
October 26, 2026 00:20
cc44420 to
4f6212a
Compare
Contributor
Author
|
/ok to test 4f6212a |
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
from
October 26, 2026 21:35
4f6212a to
dd7d842
Compare
Contributor
Author
|
/ok to test dd7d842 |
Carry forward #2399: retain borrowed setter bytes and release getter-owned storage. Keep this runtime maintenance separate from the build integration. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Carry forward #2551 and its regression test. A KeyError inside a registered getter must propagate instead of being reported as an unknown handle type. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
from
October 27, 2026 00:23
dd7d842 to
775392e
Compare
Contributor
Author
|
/ok to test 775392e |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
Apply three existing current-major helper fixes to the CUDA 12 runtime. Each fix has its own commit, keeping runtime changes separate from the packaging/CI migration.
Provenance and Review Scope
These are backports of fixes already implemented for the current bindings major. They are separate from, and not prerequisites for, making #3174–#3176 function together.
KeyErrorpropagatesAn ordinary coredump round trip would also pass with the getter leak; the existing functional tests do not prove its absence. This is a validation gap for the memory-ownership fix.
Stack / Review Boundary
Previous: #3178. The stack overview lists all six open PRs and the intended workflow.
#3174 through #3176 are intended to land together, with separate review scopes and cumulative CI at #3176; the first two are incomplete intermediate states. Release routing (#3177), maintenance policy (#3178), and the runtime fixes (#3182) follow that group. The complete proposed source tree is at #3182.
Baseline: main b4a5e5513a1f.
Counterpart Review
Compared the CUDA 12
_internal/utils.pyx,_lib/utils.pxd/.pxi,utils/__init__.py, and their focused tests with the corresponding CUDA 13 implementations. These are handwritten helper adaptations of the existing current-major fixes; generated API differences are preserved. The process-global coredump test serialization is handled separately in #3176 for both roots.Validation
At this published head, 341 CI-tool tests pass in a full Git checkout, together with full local
pre-commit run --all-files, including actionlint, Lychee, and generated-file seals. Those are tooling/source checks, not native CUDA runtime tests.Full hosted CI also passed for the complete stack at the unchanged #3182 head
775392e1a6b372b8d046a95466513bd114b05f6a: run 40456627846, attempt 2. The only retry was a self-hosted H100 runner disconnect during driver setup, before package tests began. Its replacement passed, together with the final gate; exact-head auxiliary checks are also green or intentionally skipped. This tests the cumulative stack, rather than hosted release publication or backport automation.The focused runtime regressions listed above are selected by the CUDA 12 test coverage. Existing coredump API tests do not instrument allocations or prove the absence of a leak; that ownership-validation gap remains explicit. The three runtime changes stay isolated from the preceding CI and documentation revisions.
Checklist