Repository navigation
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Oct 21, 2026
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
2 times, most recently
from
October 21, 2026 13:57
3feda76 to
0c4765b
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 21, 2026 14:09
0c4765b to
044ddc6
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 21, 2026 16:51
044ddc6 to
171b820
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
2 times, most recently
from
October 21, 2026 18:22
4deddeb to
ccb12ed
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
2 times, most recently
from
October 22, 2026 03:52
820c4ca to
560ff7d
Compare
mdboom
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 23, 2026 15:04
560ff7d to
7a269e9
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 25, 2026 23:56
7a269e9 to
595c0fd
Compare
mdboom
requested changes
Oct 26, 2026
mdboom
left a comment
Contributor
There was a problem hiding this comment.
The most important thing here is to fix the cuda-core rebinding logic.
mdboom
reviewed
Oct 26, 2026
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 26, 2026 21:35
595c0fd to
ec1fc8a
Compare
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
rwgk
force-pushed
the
rwgk/cb12-on-main-04-ci-builds
branch
from
October 27, 2026 00:23
ec1fc8a to
079a2a1
Compare
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build CUDA 12 and CUDA 13 bindings from their source roots on
main, replacing branch-sourced maintenance artifacts.bindings_config write-build-envcommand, with a small shell wrapper for platform setup.meta12andmeta13. The workplan summary exposes its JSON, including exact baseline identity and build/test decisions.ghcommands.Version Bootstrap and Platform Boundary
Copying maintenance sources does not make their later branch tags ancestors of
main. Package versions still follow standard setuptools-scm progression from the selected line's reachable tags. When suitable history is absent,bindings_scm_version.pycreates a local preview tag at a validated ancestor in a disposable build checkout. Existing suitable tags take precedence; the helper never pushes or moves tags.A plain maintenance checkout is not guaranteed to derive the intended next patch version before an appropriate milestone is reachable. The local preview instructions use an independent disposable clone because linked worktrees share tags. Preview targets are coordinated across release branches: if another branch consumes the intended version, reserve the next unused target before building again. Minor-selector changes likewise need a matching milestone. A retained milestone on validated main history, followed by removal of temporary bootstrap calls, remains a separate follow-up; no retained tag is created by this PR.
Windows ARM64 builds omit CUDA 12 because that toolkit has no Windows ARM64 build. Linux and Windows x86-64 retain both registered majors. The next layer supplies the matching test-workflow interfaces.
Stack / Review Boundary
Previous: #3174. Next: #3176. The stack overview lists all six open PRs and the intended workflow.
#3174 through #3176 are intended to land together, with separate review scopes and cumulative CI at #3176; the first two are incomplete intermediate states. Release routing (#3177), maintenance policy (#3178), and the runtime fixes (#3182) follow that group. The complete proposed source tree is at #3182.
Baseline: main b4a5e5513a1f.
Suggested Review Order
Counterpart Review
Inspected both bindings build paths and SCM selectors, their metapackage selection, the merged Core wheel and its two ABI variants, and the Linux/Windows sdist consumers. Both majors use the same planner and environment writer; Windows ARM64 deliberately excludes CUDA 12. The shared backend helper and synchronized test-bootstrap invariants remain intact.
Validation
Cumulative local checks pass in full Git checkouts: 328 CI-tool tests at #3176 and 341 at #3182, with full pre-commit at both heads, including actionlint and Lychee. Git-based workspace discovery is part of that tooling suite.
Planner regressions cover bindings-only Core reuse, matching-major testing, and full rebuilds when an exact baseline is unavailable. Local Git tests cover SCM bootstrap/progression and preservation of existing tags. A direct comparison matched all 26 build-environment values on Linux x86_64 and aarch64.
Full hosted CI passed for the combined #3174-#3176 state: run 40426114619, at
feb25b1b3d3c. This intermediate layer is not independently actionlint-clean: callers passbindings-config, while reusable test workflows still requirebuild-ctk-ver; #3176 completes those interfaces.Hosted artifact-reuse rehearsals. Two temporary draft PRs use the production resolver unchanged against successful baseline run 40426114619, at
feb25b1b3d3c1744b680bf54ff10986ed4e59953. Both actual workplans exactly match the expected selective plans; neither fell back to a full rebuild.Both complete hosted workflows passed on their first attempts, including documentation/link checks and their final aggregates. No fixes or retries were needed. These probes cover the two scenarios above; no separate Core-only or metapackage-only hosted probe is claimed.
Checklist