Repository navigation
fix(schemas): shared schema types - #206
Merged
Merged
Conversation
ColorRGB is now {red, green, blue} and ColorRGBA extends it with alpha. They are
imported from @geode/opengeodeweb-viewer/schema_types or opengeodeweb_viewer.schema_types.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The colors of set_background_color and set_text_style are now red/green/blue, like every other color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ids are now checked against their schema type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bounds of the range the color map of an attribute covers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenGeodeWeb-Microservice only defines DataId and GeodeId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JulienChampagnol
force-pushed
the
fix/shared_types
branch
from
November 20, 2026 09:32
8a4aa94 to
02f17be
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…block Like before BlockIds, their block_ids may be empty (e.g. to unhighlight every block): an array of ViewerId, BlockIds requiring at least one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BotellaA
approved these changes
Nov 20, 2026
This was referenced Nov 20, 2026
They are the picked ones among the ids of its params, which are DataId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the shared schema types of OpenGeodeWeb-Microservice (Geode-solutions/OpenGeodeWeb-Microservice#35).
src/opengeodeweb_viewer/schema_types.json, exported as@geode/opengeodeweb-viewer/schema_typesandopengeodeweb_viewer.schema_types:ColorRGB,ColorRGBA,ColorMapPoints,Visibility,Opacity,PointSize,EdgeWidth,BlockIds(an array ofViewerId),AttributeItem,AttributeRangeMinimum,AttributeRangeMaximum;ViewerId,AttributeName,Filename,Point3D, also defined (identically) by Back.ColorRGBis{red, green, blue}andColorRGBAextends it withalpha.set_background_colorandset_text_stylenow takered/green/blueinstead ofr/g/b; Front and Vease are updated in their own PRs."color": {"title": "ColorRGBA"}: about 2400 duplicated lines removed.schema_definitions.jsonships with the package so that the RPCs validate the full schemas at runtime.id: DataId,opacity: Opacity,minimum: AttributeRangeMinimuminstead ofstr/float.cube.vtmget valid uuids.Test plan
mypy -p opengeodeweb_viewer)🤖 Generated with Claude Code