Repository navigation
fix(types): shared types of the microservices - #595
Merged
Merged
Conversation
…b-Microservice Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every geode object type must have an icon: add the missing HorizonStack3D one, a stratigraphic column of horizons and erosions. The tooltip was always the type name, the map only keeps the image Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The icon of a geode object only takes a GeodeObjectType: the allowed objects map, its candidates and the object selector keep the type instead of plain strings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The types the front declared itself come from the packages defining them: - DataId and GeodeId from @geode/opengeodeweb-microservice/schema_types, app/types/identifiers.ts only declares the ids derived from them - Visibility, Opacity, EdgeWidth (was Width), PointSize (was Size), AttributeName, AttributeItem and the attribute range bounds from @geode/opengeodeweb-viewer/schema_types app/types/style.ts is removed, app/types/attribute.ts only declares the attribute types of the front. The edges width of the mesh options was typed as a Size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BotellaA
approved these changes
Nov 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # internal/stores/data_style/scene.ts
This was referenced Nov 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the shared types of the microservices instead of declaring its own (Geode-solutions/OpenGeodeWeb-Microservice#35, Geode-solutions/OpenGeodeWeb-Back#296, Geode-solutions/OpenGeodeWeb-Viewer#206).
GeodeObjectTypeandViewerObjectTypecome from@geode/opengeodeweb-microservice/data_types. The back responses, the allowed objects (Partial<Record<GeodeObjectType, AllowedObject>>) and the icons (Record<GeodeObjectType, string>,geodeObjectImage(geodeObjectType)) are keyed by it;HorizonStack3Dgets a stratigraphic column icon.DataId,GeodeIdfrom@geode/opengeodeweb-microservice/schema_types;CRSfrom@geode/opengeodeweb-back/schema_types;ColorRGB,ColorRGBA,Visibility,Opacity,EdgeWidth(wasWidth),PointSize(wasSize),AttributeName,AttributeItem,AttributeRangeMinimum,AttributeRangeMaximumfrom@geode/opengeodeweb-viewer/schema_types.app/types/style.tsis removed;app/types/identifiers.tsandapp/types/attribute.tsonly declare the front's own types.{red, green, blue}(Viewer#206).Test plan
next🤖 Generated with Claude Code