Skip to content

feat(orientation_widget): "none" marker hides the orientation widget - #205

Merged
BenPinet merged 7 commits into
nextfrom
feat/brand_identity
Nov 20, 2026
Merged

BenPinet merged 7 commits into
nextfrom
feat/brand_identity

Conversation

@SpliiT

@SpliiT SpliiT commented Nov 18, 2026

Copy link
Copy Markdown
Member

Why

Vease draws its own orientation marker (axes globe or compass dial, Geode Solutions brand identity) as a front overlay, which needs the VTK orientation widget hidden.

Same branch name in Geode-solutions/OpenGeodeWeb-Front#591, Geode-solutions/Vease#903 and Geode-solutions/Vease-Modeling#126.

What

  • set_orientation_widget accepts "none": the VTK orientation widget is disabled. "axes" and "compass" are unchanged.
  • VTK resets the marker visibility when the widget is disabled: the flag is restored, so switching back to axes or compass keeps it.
  • Schemas regenerated (npm run json): JSON schema, Python dataclass, typed schemas for the front.

Tests

  • 2 new tests in tests/test_viewer_protocols.py (none → axes; none keeps the visibility), with the existing reference images.
  • Full pytest suite passes locally (312).

set_orientation_widget accepts "none": the VTK orientation widget is disabled, so a front can draw its own orientation marker (OpenGeodeWeb-Front ogwFront.orientationOverlay). The visibility flag that VTK resets when disabling the widget is restored, so switching back to axes or compass keeps it. Schemas regenerated.
@SpliiT
SpliiT marked this pull request as ready for review November 19, 2026 13:03
@BenPinet
BenPinet merged commit 970dad6 into next Nov 20, 2026
29 checks passed
@BenPinet
BenPinet deleted the feat/brand_identity branch November 20, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants