Repository navigation
feat(orientation_widget): "none" marker hides the orientation widget - #205
Merged
Merged
Conversation
set_orientation_widget accepts "none": the VTK orientation widget is disabled, so a front can draw its own orientation marker (OpenGeodeWeb-Front ogwFront.orientationOverlay). The visibility flag that VTK resets when disabling the widget is restored, so switching back to axes or compass keeps it. Schemas regenerated.
…rand_identity # Conflicts: # requirements.txt
# Conflicts: # requirements.txt
SpliiT
marked this pull request as ready for review
November 19, 2026 13:03
JulienChampagnol
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vease draws its own orientation marker (axes globe or compass dial, Geode Solutions brand identity) as a front overlay, which needs the VTK orientation widget hidden.
Same branch name in Geode-solutions/OpenGeodeWeb-Front#591, Geode-solutions/Vease#903 and Geode-solutions/Vease-Modeling#126.
What
set_orientation_widgetaccepts"none": the VTK orientation widget is disabled."axes"and"compass"are unchanged.npm run json): JSON schema, Python dataclass, typed schemas for the front.Tests
tests/test_viewer_protocols.py(none → axes; none keeps the visibility), with the existing reference images.