Skip to content

feat(theme): let apps theme the shared chrome (Geode Solutions brand identity) - #591

Merged
BenPinet merged 36 commits into
nextfrom
feat/brand_identity
Nov 20, 2026
Merged

BenPinet merged 36 commits into
nextfrom
feat/brand_identity

Conversation

@SpliiT

@SpliiT SpliiT commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Why

Vease is being reskinned with the new Geode Solutions brand identity, in a light and a dark theme. The chrome shared from this layer was dark-only (white text, white glass, GlassCard panels forcing the dark theme), so it was unreadable in a light theme. Vease also replaces the VTK orientation marker with its own brand axes and compass.

Same branch name in Geode-solutions/Vease#903, Geode-solutions/Vease-Modeling#126 and Geode-solutions/OpenGeodeWeb-Viewer#205.

What

  • chromeTheme app config (app.config.ts, composables/chrome_theme.ts, ChromeTheme.vue): each app chooses the Vuetify theme of the floating chrome. The default stays "dark", so PEGGHy keeps its current look; Vease sets "inherit" to follow its light/dark theme.
  • Loading screen: theme colors under the chrome theme, overlay/glow/progress through --ogw-loading-* CSS variables whose fallbacks are the current values, and an ogw-loading class hook.
  • Viewer chrome (object tree, context menu, options, tooltips, tool panels) and import/file/feedback components: hard-coded white/black and the old teal (#3c9983 in the Stepper) become theme roles. Data colors (colormaps, axis colors, VTK styles) are untouched.
  • New CSS hooks with the current values as fallback: --ogw-svg-icon-filter, --ogw-svg-icon-active-filter, --ogw-mono-icon-filter, --ogw-viewer-glass-min-opacity, --ogw-dropzone-bg, --ogw-dropzone-text-shadow.
  • Front orientation overlay, opt-in with ogwFront.orientationOverlay (off by default: other apps keep the VTK marker). The viewer gets the "none" marker (OpenGeodeWeb-Viewer#205) and the front draws, in the bottom right corner at the same place and size:
    • axes (Viewer/OrientationGlobe.vue): X/Y/Z from the center of a globe crossed by horizontal strata (horizontal in the world, so up and the tilt read at a glance), north as the orange dot, click a label to look from that axis, click the globe for the plan view, azimuth/elevation readout on hover;
    • compass (Viewer/OrientationCompass.vue): dial turning with the heading and flattening with the elevation, click to face north.
    • The scene style and saved projects keep "axes"/"compass"; the overlays follow the local vtk.js camera, so they move while dragging. Geometry in pure, tested utils (orientation_gizmo.ts, orientation_compass.ts, orientation_globe.ts, orientation_strata.ts).

Known differences for PEGGHy

Not checked on screenshots yet. Small expected changes: borders use the theme border color (slightly fainter), a few hovers use primary instead of white, the error banner is surface-variant instead of grey, tooltip values use primary instead of mint.

Known limitation

Server-side screenshots (Screenshot.vue, VTK take_screenshot) don't include the front overlay, so with the overlay on they have no orientation marker.

Tests

  • Unit tests pass (the ThresholdFilter "applies the threshold again…" test is flaky under full-suite load and passes alone), including the new orientation tests.
  • Browser screenshot tests not rerun: viewer chrome screenshots are expected to change.

Draft: the e2e reference screenshots (here and in Vease) will be regenerated once the look is validated.

GlassCard panels used to force the dark theme. Apps now set ogwFront.chromeTheme in their app.config.ts: "dark" by default (unchanged for current apps), or "inherit" to follow the app's current theme. The ChromeTheme wrapper applies it to content outside a GlassCard (teleported overlays...).
White text and white glows become theme colors under the chrome theme. Overlay, dots, glows and progress colors go through CSS variables (--ogw-loading-*) whose fallbacks keep the current dark look.
Object tree, context menu, options, tooltips and tool panels use theme roles instead of hard-coded white/black. Viewer SVG icons can be recolored with --ogw-svg-icon-filter / --ogw-svg-icon-active-filter, the object tree glass with --ogw-viewer-glass-min-opacity and --ogw-mono-icon-filter. Data colors are unchanged.
…nents

Stepper (old teal hard-coded), file uploader, drag and drop (wrapped in ChromeTheme, --ogw-dropzone-* variables), CSV preview, search bar, delete dialog and snackbars use theme roles.
The ogw-loading class lets an app restyle the loading screen (Vease draws it as a brand book cover).
SVG compass in the app chrome theme: the dial turns with the camera heading (north = world +Y) and flattens with its elevation, letters stay upright, N and the needle in orange. A click turns the camera back to north, keeping its elevation and distance. Camera pose and heading math are pure functions (orientation_gizmo.ts, orientation_compass.ts).
…ntal strata

The X/Y/Z axes from the center of a sphere crossed by horizontal strata (latitude rings, horizontal in the world, so up and the tilt read at a glance; alternate tone-on-tone fills echo the slices of the Geode Solutions mark), north as the orange dot on the equator, labels in the brand font. A click on a label looks from that axis, a click on the globe shows the plan view; on hover, the view reads as azimuth and elevation (N 030° · 25°).
…K marker

With ogwFront.orientationOverlay (app.config.ts, off by default so other apps keep the VTK marker), the viewer gets the "none" marker and the front draws the scene choice in the bottom right corner: the axes globe or the compass dial, at the same place and size. The scene style and saved projects keep "axes"/"compass". Needs OpenGeodeWeb-Viewer with the "none" marker.
SpliiT and others added 4 commits November 18, 2026 13:47
…oolbar icons

Apps can align the object tree panels on their own shape system. The fallbacks keep the former look (16 px radius, 10 px padding, 28 px toolbar icons).
…ingle canvas

The strata are rendered on a detached canvas and shown as an SVG image inside the globe, so the VTK canvas stays the only <canvas> of the viewer, the one the viewer tests locate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rom Vease extensions

useChromeTheme called the Nuxt auto-import useAppConfig, which does not exist in
components bundled outside Nuxt: GlassCard threw "useAppConfig is not defined" in
Vease-Modeling. A Nuxt plugin now provides ogwFront.chromeTheme on the Vue app and
useChromeTheme injects it.
@SpliiT
SpliiT marked this pull request as ready for review November 19, 2026 13:03
BREAKING CHANGE: the apps use Phosphor icon names (ph-<name>, ph-fill ph-<name>); mdi-* names no longer render and @mdi/font is no longer loaded. The mdiIcon prop of ObjectTree/Box is renamed fontIcon.
Comment thread app/app.config.ts Resolved
@BenPinet
BenPinet merged commit d1db581 into next Nov 20, 2026
80 of 82 checks passed
@BenPinet
BenPinet deleted the feat/brand_identity branch November 20, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants