Repository navigation
fix(schemas): shared schema types - #296
Merged
Merged
Conversation
They are only used by this package and the ones depending on it, which import them from @geode/opengeodeweb-back/schema_types or opengeodeweb_back.schema_types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
geode_object_type is now validated against the values of GeodeObjectType. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenGeodeWeb-Microservice only defines DataId and GeodeId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JulienChampagnol
force-pushed
the
fix/shared_types
branch
from
November 20, 2026 09:32
7a0c4f5 to
ca08f8c
Compare
BotellaA
approved these changes
Nov 20, 2026
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the shared schema types of OpenGeodeWeb-Microservice (Geode-solutions/OpenGeodeWeb-Microservice#35).
src/opengeodeweb_back/schema_types.json, exported as@geode/opengeodeweb-back/schema_typesandopengeodeweb_back.schema_types:CRS,AttributeInfo,MeshComponent,CollectionComponent, only used by Back and the packages depending on it;ViewerId,AttributeName,Filename,Point3D, also defined (identically) by Viewer."crs": {"title": "CRS"}: about 1800 duplicated lines removed.schema_definitions.jsonships with the package so that the routes validate the full schemas at runtime.id: DataId,geode_id: GeodeId,filename: Filenameinstead ofstr.geode_object_typeis validated against the values ofGeodeObjectType(an unknown type is a 400), andobjects_to_loadreturnsGeodeObjectType.CRSdataclass.Test plan
schema_definitions.json🤖 Generated with Claude Code