Repository navigation
Conversation
The promoted-buffer size was computed as `(int) Zfp.countValues(zfpShape) * zfpType.getByteCount()`, so the multiplication happened in int and silently wrapped for large chunks. A 1024^3 int8 chunk wrapped to 0 and `promote` then threw BufferOverflowException outside the try/catch; a 512x1024x1024 chunk wrapped to Integer.MIN_VALUE and `allocate` threw IllegalArgumentException. Compute the size as a long and reject oversized chunks with a ZarrException before allocating. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
normanrz
approved these changes
Sep 4, 2026
normanrz
requested changes
Sep 10, 2026
normanrz
left a comment
normanrz
left a comment
Member
There was a problem hiding this comment.
I think we should not include this in zarr-java directly. The reason is that this adds a heavy and potentially controversial dependency. However, we can put the codec implementation in the zfp-java repo. There we can also call CodecRegistry.addCodec so that it hooks itself into zarr-java.
We can add a link to the zfp-java repo here in the readme, though.
zfp needs a native library, which zarr-java should not force on all its users. The codec now lives in scalableminds/zfp-java and registers itself through CodecRegistry; the user guide points there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the review, the zfp codec no longer lives in zarr-java, so zarr-java doesn't depend on the native zfp library. The codec moved to zfp-java (scalableminds/zfp-java#2), which registers it through
CodecRegistry.addType:What's left here is a short section in the user guide pointing to zfp-java.
🤖 Generated with Claude Code