Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
============================================
+ Coverage 94.90% 95.15% +0.24%
- Complexity 375 395 +20
============================================
Files 59 59
Lines 981 1031 +50
============================================
+ Hits 931 981 +50
Misses 50 50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KalimeroMK
reviewed
Oct 28, 2026
… restore previous ones
…-pause` in test - `RunCommand` accepts an optional loop and starts it once around all queues, so a signal received between two queues sets the exit flag instead of reaching the default handler. - Document and test that handlers installed by `canContinue()` outside of `start()`/`finish()` are kept. - Pass `--pause` through `ArrayInput` parameters, since `Command::run()` re-binds the input.
samdark
force-pushed
the
fix-347-signal-loop-handlers
branch
from
October 29, 2026 21:56
1f82e0e to
92b07c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #347.
Keep existing application signal handlers intact when a
SignalLoopis created. Queue consumers and commands take over signal handling while processing messages, finish the current message before stopping, and restore application handlers when processing ends or fails. Commands that process several queues keep graceful shutdown active between queues.Add
ScopedLoopInterfacefor custom loops that need setup and cleanup around consumption. Preserve standalonecanContinue()behavior, where the loop keeps its signal handlers for the rest of the process. Document how to stop and pause workers, share a loop when configuring commands manually, and restore handlers in custom execution loops.Summary by Sourcery
Scope SignalLoop signal handling to message consumption while preserving application handlers and graceful shutdown behavior.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: