Repository navigation
Temporary: CI run of the .slnx watcher fix (do not merge) - #4
Closed
xperiandri wants to merge 2 commits into
Closed
xperiandri wants to merge 2 commits into
xperiandri wants to merge 2 commits into
Conversation
The watcher of the solution file was set up only when the name of the solution ended in ".sln", and its rename handler checked the same. A solution in the newer, XML based, .slnx format got no watcher, so a change of the solution (such as adding a project) did not reload the list of .resx files. The project file watcher was not affected. IsSolutionFileName recognizes both extensions, without regard to case, and both checks use it. The check in the rename handler was case sensitive before and is not any more. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Nine tests for IsSolutionFileName: the .sln and .slnx formats, different case, a project file and a solution filter, an extension in the middle of the path, an empty name and null. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the Build workflow on the branch inside the fork, to build it with the .NET Framework 4.8.1 targeting pack of the runner. This pull request is closed afterwards; the real pull request is in the original repository.
🤖 Generated with Claude Code