Repository navigation
Report the scenarios that are left out, and why - #409
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
Scenarios the environment cannot run, or that belong to another configuration, were filtered out without a word. List them before the run with the reason, separating what the environment lacks from what is not part of the configuration being tested, and add the list to the job summary on GitHub Actions. With WP_CLI_TEST_STRICT_REQUIREMENTS set, the run stops before any scenario starts when the environment lacks something, or when the database cannot be reached, instead of leaving scenarios out or falling back to SQLite. The database check no longer needs the test database to exist, which the scenarios drop themselves, so that a run no longer falls back to SQLite just because the previous one left no test database behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #392.
Scenarios that cannot run in an environment, or that belong to another configuration of the test matrix, were filtered out silently, so a green run said nothing about what was not tested.
Before the run, the scenarios that are left out are now listed together with the reason, in two groups:
On GitHub Actions, the list is also added to the job summary.
Setting
WP_CLI_TEST_STRICT_REQUIREMENTSstops the run before any scenario starts when the environment lacks something the scenarios need, or when the database cannot be reached, instead of leaving scenarios out or silently falling back to SQLite. This is meant for CI, where a missing requirement is a problem with the environment.While testing this, it turned out that the database check before a run needed the test database to exist. As the scenarios drop that database themselves, a run could silently switch to SQLite just because the previous run left no test database behind. The check now verifies that the test user may create the database instead.
Example from
media-commandwithout the imagick and exif extensions: