Repository navigation
Trim fixed per-scenario overhead - #403
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
Remove the run directory and the suite cache directory of a scenario in the background, as no later scenario uses their unique paths. The next scenario no longer waits for thousands of files to be deleted. A background process that is expected to listen on a port no longer waits a full second before the scenario continues, but only until it accepts connections. If the port is already taken before the process starts, the full second is still waited, so that a process failing to bind to it is noticed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
bug
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #388.
After each scenario, the next one waited for its run directory to be deleted, about 3,800 files for a WordPress installation, or roughly 50 ms. Run directories and suite cache directories have unique names that no later scenario uses, so they are now removed in the background. Windows keeps removing them right away.
Starting a background process always waited a full second. When the command shows which local port the process listens on, as for the PHP built-in web server or
wp server, the scenario now continues as soon as the port accepts connections. A process that exits early is still reported as before. If the port was already taken before the process started, the full second is still waited, so a process failing to bind to it does not go unnoticed.Measurements are recorded on #388.