Repository navigation
Manage the test database over a single connection - #402
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
Dropping and creating the test database and restoring a cached installation each started a mysql client process. Run them over one persistent connection from the Behat process instead, which also proves the database can be reached without a separate check per scenario. The mysql client is still used when the mysqli extension is not available or no connection can be made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #386.
Every scenario started at least two
mysqlclient processes before doing anything, to test the connection and to drop the test database. Scenarios installing WordPress started two more, to create the database and to restore the cached installation.These operations now run over one persistent connection from the Behat process. The connection itself proves that the database can be reached, so there is no separate check per scenario anymore. The
mysqlclient is still used when the mysqli extension is not available or no connection can be made. The database ends up in the same state as before.Measurements are recorded on #386.