Repository navigation
Launch WP-CLI processes with cheaper PHP settings - #401
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
Turn Xdebug off for the processes launched by the tests unless code coverage is collected or a mode or session is requested explicitly, and keep the code of WP-CLI and the project under test in a file-based opcode cache. Files below the temporary directory, where scenarios create and rewrite their files, are never cached. WP_CLI_TEST_PHP_TUNING=off launches the processes with the PHP configuration as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #385.
Nearly all of a test run is spent in the
wpprocesses the scenarios launch, and each of them starts PHP from scratch: with Xdebug active when it is installed, and compiling WP-CLI and the package code again although it does not change during a run.The launched processes now run with Xdebug off, unless code coverage is collected or
XDEBUG_MODE,XDEBUG_SESSIONorXDEBUG_CONFIGis set, so step debugging keeps working (see #257). WP-CLI and the project under test are kept in a file-based opcode cache. Everything below the temporary directory, where scenarios write their files, stays uncached, and a new scenario checks that a rewritten file is always run in its current version.WP_CLI_TEST_PHP_TUNING=offrestores the previous behavior. Measurements are recorded on #385.