Skip to content

Remove roave/security-advisories - #396

Merged
schlessera merged 1 commit into
mainfrom
remove-roave-security-advisories
Oct 30, 2026
Merged

schlessera merged 1 commit into
mainfrom
remove-roave-security-advisories

Conversation

@schlessera

Copy link
Copy Markdown
Member

Part of wp-cli/.github#308.

Since Composer 2.9, Composer refuses to install packages with known security advisories by default, which the release post says fully replaces roave/security-advisories. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can no longer be installed on the older PHP versions we test on.

Composer's check covers the dependencies only, not PHP itself. CI runs the latest Composer, so every test job still blocks vulnerable dependencies, including those on older PHP versions.

Composer 2.9+ blocks packages with known security advisories by default, which fully replaces this package. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can't be installed on the older PHP versions we test on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera requested a review from a team as a code owner October 30, 2026 18:36
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3abf84c1-fb1a-4ec1-80fe-d3a06a2ec15c
Commits

Reviewing files that changed from the base of the PR and between 9298472 and faae01d.

Files selected for processing: 1
  • composer.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@schlessera
schlessera merged commit b533a56 into main Oct 30, 2026
71 checks passed
@schlessera
schlessera deleted the remove-roave-security-advisories branch October 30, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant