Repository navigation
Remove roave/security-advisories - #1184
Conversation
Composer 2.9+ blocks packages with known security advisories by default, which fully replaces this package. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can't be installed on the older PHP versions we test on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update development requirements composer.json |
Removed the roave/security-advisories dev-latest constraint from require-dev. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: brianhenryie
Merge Risk: 
Minimal · up to 42ac5
-
The dependency removal is mergeable after normal checks; the inspected test jobs retain Composer’s advisory protection.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Part of wp-cli/.github#308.
Since Composer 2.9, Composer refuses to install packages with known security advisories by default, which the release post says fully replaces
roave/security-advisories. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can no longer be installed on the older PHP versions we test on.Composer's check covers the dependencies only, not PHP itself. CI runs the latest Composer, so every test job still blocks vulnerable dependencies, including those on older PHP versions.
Summary by CodeRabbit