Skip to content

Remove roave/security-advisories - #1184

Merged
schlessera merged 1 commit into
mainfrom
remove-roave-security-advisories
Oct 30, 2026
Merged

schlessera merged 1 commit into
mainfrom
remove-roave-security-advisories

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Part of wp-cli/.github#308.

Since Composer 2.9, Composer refuses to install packages with known security advisories by default, which the release post says fully replaces roave/security-advisories. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can no longer be installed on the older PHP versions we test on.

Composer's check covers the dependencies only, not PHP itself. CI runs the latest Composer, so every test job still blocks vulnerable dependencies, including those on older PHP versions.

Summary by CodeRabbit

  • Chores
    • Updated the development configuration.

Composer 2.9+ blocks packages with known security advisories by default, which fully replaces this package. Since its latest update, the package also conflicts with every PHP version without the newest security release, so it can't be installed on the older PHP versions we test on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera requested a review from a team as a code owner October 30, 2026 18:36
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 140d63b3-4139-4a52-917d-453a099d62f6
Commits

Reviewing files that changed from the base of the PR and between ef46c85 and 42ac5d1.

Files ignored due to path filters: 1
  • composer.lock is excluded by !**/*.lock
Files selected for processing: 1
  • composer.json
Files with no reviewable changes: 1
  • composer.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The roave/security-advisories dev-latest constraint was removed from the require-dev section of composer.json.

Changes: Development dependency update

Layer / File(s) Summary
Update development requirements
composer.json
Removed the roave/security-advisories dev-latest constraint from require-dev.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: brianhenryie

Merge Risk: Minimal · up to 42ac5

The dependency removal is mergeable after normal checks; the inspected test jobs retain Composer’s advisory protection.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the roave/security-advisories dependency.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@schlessera
schlessera merged commit d3d2580 into main Oct 30, 2026
61 checks passed
@schlessera
schlessera deleted the remove-roave-security-advisories branch October 30, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant