Skip to content

Declare that editing scenarios need ex - #236

Merged
schlessera merged 1 commit into
mainfrom
feature/require-bin-ex
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
feature/require-bin-ex

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Part of wp-cli/wp-cli-tests#393.

The scenarios in config-edit.feature use ex as the editor, and fail where it is not installed. Tagging them with @require-bin-ex lets the test framework report them as not run in such environments instead, once wp-cli/wp-cli-tests#410 is in. Until then, the tag has no effect.

Summary by CodeRabbit

No end-user-facing changes in this update.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The config-edit feature file now includes the @require-bin-ex tag.

Changes: Config Edit Feature Tag

Layer / File(s) Summary
Tag the config-edit feature
features/config-edit.feature
The feature file adds the @require-bin-ex tag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: swissspidy

Merge Risk: Minimal · up to f8d30

No merge-blocking issues were identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added command:config-edit Related to 'config edit' command scope:testing Related to testing labels Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@schlessera
schlessera marked this pull request as ready for review November 2, 2026 03:33
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 03:33
@schlessera
schlessera merged commit 9161d14 into main Nov 2, 2026
101 checks passed
@schlessera
schlessera deleted the feature/require-bin-ex branch November 2, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:config-edit Related to 'config edit' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant