Skip to content

Drop roave/security-advisories in CI when it conflicts with the PHP in use #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 5 commits into from
Oct 29, 2026
Merged

Drop roave/security-advisories in CI when it conflicts with the PHP in use #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9104a6
Drop roave/security-advisories on PHP < 8.2 in CI
claude Oct 29, 2026
c5da57f
Drop roave/security-advisories on all PHP versions
claude Oct 29, 2026
fda9694
Only drop roave/security-advisories when it conflicts with the PHP in…
claude Oct 29, 2026
3910ab1
Link setup-php security release notes in roave comment
claude Oct 29, 2026
c7459ef
Update PHP to the latest patch on Windows runners
claude Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/reusable-functional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ jobs:
tools: composer
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Windows runners don't pick up patched PHP builds on their own (shivammathur/setup-php#1139).
update: ${{ runner.os == 'Windows' }}

- name: Change ImageMagick policy to allow pdf->png conversion.
# Keyed on the actual runner rather than the `os` input, and tolerant of
Expand All @@ -188,6 +190,30 @@ jobs:
shell: bash
run: echo "value=$(date -u +%Y-%W)" >> "$GITHUB_OUTPUT"

# roave/security-advisories also conflicts with PHP releases that have known
# advisories, so it can't install on those (Roave/SecurityAdvisories#155).
# Drop it only when it conflicts with the PHP version in use. setup-php ships
# builds with security fixes backported, even for EOL versions, so this is
# safe on CI (shivammathur/setup-php#1139).
- name: Drop roave/security-advisories if it conflicts with this PHP version
shell: bash
run: |
php -r 'exit(isset(json_decode(file_get_contents("composer.json"), true)["require-dev"]["roave/security-advisories"]) ? 0 : 1);' || exit 0
export CONFLICT="$(composer show --available --format=json roave/security-advisories dev-latest | php -r 'echo json_decode(stream_get_contents(STDIN), true)["conflicts"]["php"] ?? "";')"
echo "roave/security-advisories conflicts with php ${CONFLICT:-(none)}"
if php -r '
foreach (preg_split("/\s*\|\|?\s*/", getenv("CONFLICT"), -1, PREG_SPLIT_NO_EMPTY) as $range) {
$hit = true;
foreach (preg_split("/\s*,\s*|\s+/", $range) as $c) {
preg_match("/^(<=|>=|<|>|==|=|!=)?v?(.+)$/", $c, $m);
$hit = $hit && version_compare(PHP_VERSION, $m[2], $m[1] ?: "==");
}
if ($hit) exit(0);
}
exit(1);'; then
composer remove --dev --no-update --no-interaction roave/security-advisories
fi

- name: Install Composer dependencies & cache dependencies
uses: "ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda" # 4.0.0
with:
Expand Down
26 changes: 26 additions & 0 deletions .github/workflows/reusable-unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ jobs:
tools: composer,cs2pr
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Windows runners don't pick up patched PHP builds on their own (shivammathur/setup-php#1139).
update: ${{ runner.os == 'Windows' }}

# WP-CLI packages do not commit a lock file, so `composer update` resolves
# dependencies on every run while the cache key stays pinned to composer.json.
Expand All @@ -59,6 +61,30 @@ jobs:
shell: bash
run: echo "value=$(date -u +%Y-%W)" >> "$GITHUB_OUTPUT"

# roave/security-advisories also conflicts with PHP releases that have known
# advisories, so it can't install on those (Roave/SecurityAdvisories#155).
# Drop it only when it conflicts with the PHP version in use. setup-php ships
# builds with security fixes backported, even for EOL versions, so this is
# safe on CI (shivammathur/setup-php#1139).
- name: Drop roave/security-advisories if it conflicts with this PHP version
shell: bash
run: |
php -r 'exit(isset(json_decode(file_get_contents("composer.json"), true)["require-dev"]["roave/security-advisories"]) ? 0 : 1);' || exit 0
export CONFLICT="$(composer show --available --format=json roave/security-advisories dev-latest | php -r 'echo json_decode(stream_get_contents(STDIN), true)["conflicts"]["php"] ?? "";')"
echo "roave/security-advisories conflicts with php ${CONFLICT:-(none)}"
if php -r '
foreach (preg_split("/\s*\|\|?\s*/", getenv("CONFLICT"), -1, PREG_SPLIT_NO_EMPTY) as $range) {
$hit = true;
foreach (preg_split("/\s*,\s*|\s+/", $range) as $c) {
preg_match("/^(<=|>=|<|>|==|=|!=)?v?(.+)$/", $c, $m);
$hit = $hit && version_compare(PHP_VERSION, $m[2], $m[1] ?: "==");
}
if ($hit) exit(0);
}
exit(1);'; then
composer remove --dev --no-update --no-interaction roave/security-advisories
fi

- name: Install Composer dependencies & cache dependencies
uses: "ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda" # 4.0.0
with:
Expand Down
Loading