Repository navigation
Conversation
Keep Node's getOrganizationDataIntegration, updateOrganizationDataIntegration and deleteOrganizationDataIntegration instead of the derived listDataIntegrationOrganization/update.../delete... names, and name POST /data-integrations/finish finish_connection instead of create_finish. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from dan
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPreserves three existing Node Pipes method names and names the finish endpoint
Acknowledged behavior: dandorman explicitly states that Python and Ruby snippets will change from Reviews (1) · Last reviewed commit: "fix(node): keep shipped Pipes method nam..." · Reviewed by Greptile |
thompsongl
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two naming fixes found while regenerating Pipes in workos-node:
operationOverrides.node.json: pinsGET|PUT|DELETE /data-integrations/{slug}/organizationto the names Node already ships (getOrganizationDataIntegration,updateOrganizationDataIntegration,deleteOrganizationDataIntegration). Without these, a Node regen renames them tolistDataIntegrationOrganization/updateDataIntegrationOrganization/deleteDataIntegrationOrganization, which breaks callers. Node-only; Python and Ruby already ship the derived names.operation-hints.ts:POST /data-integrations/finish→finish_connection(Node:finishConnection) instead of the verb heuristic'screate_finish. This matches the docs page slugfinish-connection. It applies to every SDK, so the generated Python and Ruby docs snippets that currently saycreate_finishwill change on the next regen.I checked this by running
sdk:generate --lang node --services Pipesagainst workos-node with and without the overrides: without them you get the three renamed methods; with them the method list matches HEAD plusfinishConnection.Companion Node PR: workos/workos-node#1745
Link to Devin session: https://app.devin.ai/sessions/bf88ed3db48d4419b9b38b37abc715d7
Open in Devin Desktop: https://app.devin.ai/desktop/session/bf88ed3db48d4419b9b38b37abc715d7?variant=devin
Requested by: @dandorman