Skip to content

fix(node): keep shipped Pipes method names and name the finish endpoint - #248

Open
dandorman wants to merge 1 commit into
mainfrom
devin/1793307823-pipes-node-names
Open

dandorman wants to merge 1 commit into
mainfrom
devin/1793307823-pipes-node-names

Conversation

@dandorman

@dandorman dandorman commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two naming fixes found while regenerating Pipes in workos-node:

  • operationOverrides.node.json: pins GET|PUT|DELETE /data-integrations/{slug}/organization to the names Node already ships (getOrganizationDataIntegration, updateOrganizationDataIntegration, deleteOrganizationDataIntegration). Without these, a Node regen renames them to listDataIntegrationOrganization / updateDataIntegrationOrganization / deleteDataIntegrationOrganization, which breaks callers. Node-only; Python and Ruby already ship the derived names.
  • operation-hints.ts: POST /data-integrations/finish → finish_connection (Node: finishConnection) instead of the verb heuristic's create_finish. This matches the docs page slug finish-connection. It applies to every SDK, so the generated Python and Ruby docs snippets that currently say create_finish will change on the next regen.

I checked this by running sdk:generate --lang node --services Pipes against workos-node with and without the overrides: without them you get the three renamed methods; with them the method list matches HEAD plus finishConnection.

Companion Node PR: workos/workos-node#1745

Link to Devin session: https://app.devin.ai/sessions/bf88ed3db48d4419b9b38b37abc715d7
Open in Devin Desktop: https://app.devin.ai/desktop/session/bf88ed3db48d4419b9b38b37abc715d7?variant=devin
Requested by: @dandorman

Keep Node's getOrganizationDataIntegration, updateOrganizationDataIntegration
and deleteOrganizationDataIntegration instead of the derived
listDataIntegrationOrganization/update.../delete... names, and name
POST /data-integrations/finish finish_connection instead of create_finish.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from dan

no immediate action required: if i want you to make a new PR for the Node SDK that basically uses the oagen tooling to make it, can you do that?

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Preserves three existing Node Pipes method names and names the finish endpoint finish_connection.

  • Node regeneration keeps the shipped organization integration method names.
  • The finish endpoint gets a name that describes its action.

Acknowledged behavior: dandorman explicitly states that Python and Ruby snippets will change from create_finish on the next regeneration.

Reviews (1) · Last reviewed commit: "fix(node): keep shipped Pipes method nam..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants