[austinderrick]

#1535 added two data providers to ListsTest that are not static. PHPUnit 9 on develop accepts that, but the PHPUnit version used on wip/1.3 requires static data providers, so since develop was merged into wip/1.3 the backend module tests fail on every PHP version:

Data Provider method Backend\Tests\Widgets\ListsTest::keyOnlyRecordKeysProvider() is not static
Data Provider method Backend\Tests\Widgets\ListsTest::fullSelectRecordKeysProvider() is not static

Both providers return plain arrays and do not use $this, so they can be made static. With this change the backend module tests pass (629 tests).

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 39d3eecd-898a-4935-9845-b6cfd9ba4561

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn