Repository navigation
Conversation
Member
Author
|
@salty-hambot review |
ClayMav
marked this pull request as ready for review
November 12, 2026 23:51
sfishel18
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that
cursor.attach()transfers event delivery on SQL sessions that support attachment, while its duplicate guard only protects one connection. Other live connections can reattach or cancel the execution, so callers must coordinate the handoff.This is the approved documentation follow-up to #95 and Simon's ownership and cancellation comments. It updates the README and public method docstring.
Related Issues
WBC-1934
Verification
uv run pre-commit run --all-files: all hooks passed.79eb0e2.Runtime tests were not rerun locally for documentation changes. CI passed on Python 3.10 through 3.14, hosted pre-commit passed, and Salty reviewed with no findings on
a1dce3e5179faa4a617d0974b599b27734ace893.Requester Checklist
Visual Proof
Size Justification (if L/XL)
N/A, 11 added documentation lines.
Reviewer Checklist
Implemented by GPT-6.1 Sol through T3 Code's Codex harness, with an independent agent review.