Skip to content

CI: fail when an example's trace exceeds its size budget #496

Closed

Description

@vishnuv688

Part of #494.

Problem

Nothing stops a change from making traces heavier, and two planned features (#494's page-resources and dense filmstrip work) grow them by design. Today a size regression is only noticed when someone opens a zip.

Proposal

The examples-smoke CI job already records real trace zips for all four adapters and checks them with pnpm smoke:assert against packages/conformance/smoke/expectations/*.json. Add a byte budget per expectation file and fail when an example's zips exceed it, naming the example, the size and the budget.

Budgets should start from the sizes the job currently produces, with headroom, and be lowered when a size win lands so the win cannot be undone silently.

Activity

  1. self-assigned this
    on Oct 29, 2026
  2. vishnuv688 commented on Oct 29, 2026

    @vishnuv688
    MemberAuthor

    Implemented in #509 (stacked on #508). It closes this issue when it reaches main.

  3. added a commit that references this issue on Oct 30, 2026
    0eac4fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions