Skip to content

fix: avoid category-based audit comparison lookup failures - #992

Merged
rachaelrenk merged 1 commit into
mainfrom
factory/fix-consistency-comparison-stopiteration
Nov 4, 2026
Merged

rachaelrenk merged 1 commit into
mainfrom
factory/fix-consistency-comparison-stopiteration

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Summary

  • Replace the temporary category-based lookup that raised StopIteration with a read-only lookup by stable claim pair; absent history returns null and ambiguous history blocks comparison.
  • Use saved metadata only as historical context, require fresh adjudication, and run regression coverage in CI. Audit state and public docs stay unchanged.

Related issues

Audit-state PR #876 (context only); request.

Validation

  • Reproduced the original exception against chore: docs consistency audit state #876's saved state; the new command finds its permissions-category/cli-topic entry without changing input bytes and returns null for empty history.
  • All 65 audit tests pass (five new cases failed before implementation); pinned benchmark passes 24/24 cases and 6/6 negative controls; Python compilation and whitespace checks pass.
  • Changed-file style/UI checks pass (0 public pages applicable). trunk check unavailable: CLI not installed; site build not run for this Python/workflow-only change.

Follow-ups

The full audit was not rerun; saved findings remain unreverified by this fix.

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 4, 2026 9:55pm UTC

Request Review

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp, requested by @rachaelrenk.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@cla-bot cla-bot Bot added the cla-signed label Nov 4, 2026
@warp-agent-staging warp-agent-staging Bot added the factory:docs-factory Label associated to the "docs-factory" factory label Nov 4, 2026
@rachaelrenk
rachaelrenk marked this pull request as ready for review November 4, 2026 22:34
@rachaelrenk
rachaelrenk merged commit 90535b6 into main Nov 4, 2026
27 checks passed
@rachaelrenk
rachaelrenk deleted the factory/fix-consistency-comparison-stopiteration branch November 4, 2026 22:40

This branch was successfully deployed

1 active deployment
Preview — 1618ea80 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:docs-factory Label associated to the "docs-factory" factory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant