Repository navigation
docs: Separate provider ZDR from analytics and product storage - #1021
Open
warp-agent-staging[bot] wants to merge 12 commits into
Open
warp-agent-staging[bot] wants to merge 12 commits into
warp-agent-staging[bot] wants to merge 12 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
There was a problem hiding this comment.
Overview
This draft separates provider ZDR, analytics, and product storage and adds Terminal and Factory review steps. Publication is waiting for Engineering/Security confirmation of provider coverage and exception completeness.
Verdict
Checks: build pass, tests pass, CI green, visual proof present
Found: 0 critical, 0 important, 0 suggestions, 0 nits; 1 question
Responding as Docs Factory (V2): Open session · View in factory
hongyi-chen
reviewed
Nov 12, 2026
Address review feedback without restoring universal retention or unsupported BYOK training assurances. Preserve model exceptions and the Engineering/Security publication hold. Co-Authored-By: Oz <oz-agent@warp.dev>
Narrow unconfirmed auxiliary coverage, restore requested BYOK context, and answer training directly. Keep provider-contract and Self-improvement deployment questions explicit in PR evidence. Co-Authored-By: Oz <oz-agent@warp.dev>
Preserve remote ea28fdb verbatim for the FAQ and BYOK sections, including the qualified training answer and removal of an unsupported blanket BYOK no-training claim. Co-Authored-By: Oz <oz-agent@warp.dev>
Organize the factory entry point around provider coverage, collection and storage, and plan controls. Restructure browser procedures around defaults, applicable overrides, and fresh-run checks while preserving policy qualifications and canonical anchors. Co-Authored-By: Warp <agent@warp.dev>
Clarify definition management, save-versus-apply checks, feature-specific tests, and cross-factory router access. Scope admin controls, add browser collection guidance, and record the deferred factory-plan update in a source TODO. Co-Authored-By: Warp <agent@warp.dev>
rachaelrenk
marked this pull request as ready for review
November 13, 2026 21:08
Apply editorial review revisions, move shared provider retention and storage guidance to Support, and add direct factory ZDR discovery routes. Preserve Enterprise policy anchors and leave compliance evidence and pricing follow-ups separate. Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
Give factory retention guidance its own Infrastructure page, preserve the original section anchors, and retarget related documentation links. Keep shared policy in Support and detailed procedures in agent configuration. Co-Authored-By: Warp <agent@warp.dev>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this feature does
Customers could not find ZDR guidance in the Factories tab, and existing pages confused provider retention with Warp's analytics and saved conversations. This documentation update adds a dedicated factory ZDR page, moves the shared policy to Support, and provides browser-based configuration and verification steps. It explains which settings affect provider requests, improvement collection, and stored run data without promising new privacy controls.
Summary
Engineering and Security confirmation remains outstanding for the items below.
Pending local follow-up: The standalone factory ZDR extraction and incoming-link updates are implemented and validated locally on top of
151e55bc, but are not yet committed or pushed. The ownership map below describes that revised working tree.This is a documentation correction, not a new privacy feature. No new retention periods, deletion commitments, or enforcement guarantees are asserted.
Content design plan
Audience and job: Customers deciding whether and how to use a factory with sensitive work, including customers without Warp Terminal.
Problem and outcome: Conflicting answers and scattered instructions made customers assemble the policy themselves. Readers should be able to find the answer, identify whose provider account they use, configure the relevant settings, understand what remains stored, and distinguish preferences from enforceable restrictions.
Goals: Readers can identify applicable provider coverage, distinguish collection from saved run data, and reach the correct browser configuration procedure.
Purpose and value: Extract existing factory retention guidance into
factories/zero-data-retention.mdxso Infrastructure contains distinct destinations for deployment and ZDR, rather than adjacent links to one page.Content type, skill, and template: Conceptual decision guide using
draft_conceptualand.agents/templates/conceptual.md. Procedures remain in Configuring factory agents.High-impact scenarios: Covers Warp-managed inference, customer provider accounts, direct third-party harnesses, collection/storage, plan controls, and dashboard/GitHub setup routes. Excludes new retention guarantees, contract approval, repeated procedures, and deferred lower-tier browser eligibility.
Canonical information versus guidance and discovery
Privacy and data control in Support is the canonical home of the Warp-wide ZDR policy. The dedicated factory ZDR page applies that policy to factories. Infrastructure and security retains deployment and data-flow details, with a short link to the ZDR page. Overview and sidebar links are discovery routes, not policy owners.
Factory customer journey
Editorial boundary: Preserve local warnings, useful training/BYOK explanations, and storage consequences. Do not duplicate full policy text or imply that source review proves deployed behavior or contract coverage.
Customer starting point
After merge, share ZDR for factory inference for coverage limits and browser-based configuration steps. Existing infrastructure-page anchors remain usable.
Unverified claims
Each item below needs confirmation or a narrower documentation statement. The listed functions indicate the expertise needed, not assigned reviewers.
Fixed-IP action — Engineering: verify production inference egress for the two addresses in
factories/infrastructure-and-security.mdx, "Networking for BYO inference endpoints." Confirm the claim and resolve itsVERIFYmarker, or correct/remove the fixed-IP instruction before merge.Deferred follow-ups
TODO(factory-plans)in the Admin Panel source as the handoff. Do not equate Terminal Free with a factory plan or anticipate new pricing behavior.Documentation risk
Risk: engineering-review-required
Rationale: Changes security, privacy, inference, storage, and configuration guidance; contract scope and production behavior still need confirmation.
Source files consulted: warp/app/src/settings_view/privacy_page.rs; warp-server/logic/ai/util.go, logic/ai/ambient_agents/sources/agent_config.go, logic/factoryfile/resolution/automation.go; warp-server/client/packages/factory/src/pages/FactoryCode/index.tsx, CodeBrowser.tsx, useEditingSession.ts; warp-server/client/src/components/admin/team/PrivacySettings.tsx, admin/SettingStatusFooter.tsx; standard billing/config/tiers policy inheritance
Requested engineering reviewers: none — prior source-owner resolution returned teams, not one certain human owner
Engineering review status: pending
Docs override: none
Validation and evidence
The local extraction passes typecheck, build, heading tests, metadata, and whitespace checks: 5,059 internal links, zero broken. The new page and original infrastructure page were reread in full and checked together. Focused style checks completed with warnings, not a clean pass.
Validation results, source evidence, and limitations
a688be1freported 149 findings versus a same-file baseline of 144. No bulk auto-fixes.577dc772reported zero issues across 19 pages using client snapshot1e6c3ae465d6a925a9b97ae03877aaadd159b8f1(October 23). It is not a current live-dashboard check. The configuration compression check passed below 1,500 words./404conflict. Python reports a LibreSSL warning. Dependencies were unchanged; installation was not rerun.warp-server@384ff47087fff8efc5256973ba37500aa409263f; earlier override review used97a0d5c5c4c5d32d3b5e33ab2a5b912a34ea1fc1. The initial draft consultedwarp-server@a816b38fb616cd4caaee3efd43f55c521e69df33andwarp@0b2db6e0bf3fa3c19f4c1a94899eb67c634a6973. Source presence is not deployment or contract evidence.Editorial review conversation.
Co-Authored-By: Oz oz-agent@warp.dev
Co-Authored-By: Warp agent@warp.dev
Computer-use screenshots (10)
Pricing FAQ scrolled to "How can I enable Zero Data Retention in Warp?" with answer beneath
Factory ZDR section showing defaults, coverage limits and procedure links
Dashboard-managed procedure with six numbered steps
GitHub-backed procedure with six numbered steps and start of Checking new runs
Common Checking new runs subsection
GitHub-backed procedure reached via link, with shared Checking new runs below
Pricing FAQ answer for enabling Zero Data Retention in Warp
Integrated training FAQ with both answer paragraphs visible
Training FAQ section, both paragraphs visible, header not obstructing
Integrated BYOK ZDR section with all three paragraphs visible