Skip to content

fix: recover bounded progress partition fact overflows - #852

Open
efraespada wants to merge 2 commits into
developfrom
bugfix/830-progress-partition-rejects-per-file-implemented-text-with-schema-string-long-and-no-file-identity
Open

efraespada wants to merge 2 commits into
developfrom
bugfix/830-progress-partition-rejects-per-file-implemented-text-with-schema-string-long-and-no-file-identity

Conversation

@efraespada

@efraespada efraespada commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

An overlong per-file progress fact currently aborts a complete comparison with only an array position. This change verifies the returned part/path/unit, locale and selected limit, then requests one replacement for that same immutable part. Persistent overflow reports exact safe identities and Unicode counts while preserving the previous published progress.

What changed

  • Preflight every original and possible replacement envelope before the first part query. Preserve source, schemas, model configuration, all capacity limits, full aggregation and freshness checks.
  • Keep provider, cancellation and unrelated validation failures distinct. Never copy rejected prose, trim facts, recollect source or issue a third part query.
  • Add localized closed recovery diagnostics, a focused SDD, operator documentation, catalog evidence and exhaustive coverage budgets for the four new runtime modules.
  • State the existing final completion equivalence explicitly in both directions. Keep the final validator unchanged and reject both contradictory percentages without normalization or automatic repair.

Validation

  • Six native-adapter regressions failed before the fix; all 86 focused cases pass in the complete suite, including a complete 887-path / 952-unit immutable comparison and publication/stale/failure cases.
  • Full local coverage passes: 849 Jest suites / 16,386 tests (35 existing skips); 267 extension tests at 100% all metrics; all coverage budgets and the setup acceptance validator pass.
  • Local LCOV against 9d391572: 83/83 modified runtime lines covered, zero misses or partials. All four new runtime modules have 100% lines, statements, branches and functions.
  • Remote current-head review, platform checks and Codecov remain pending; local LCOV does not establish remote acceptance.
  • Typecheck, lint, documentation, specification, workflow, npm package and package smoke validation pass. Graphify updated.

Review notes

No new configuration, response schema, permissions or stored-state migration. Action/CLI/API bundles are regenerated normally. This addresses the recurring Commit blocker in #837; its independent extension findings and platform acceptance remain separate gates. Protected-path approval, complete review and correct-base Codecov 100% modified lines with zero misses or partials are required before merge.

Closes #830.

…schema-string-long-and-no-file-identity: recover bounded progress partition fact overflows
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Nov 2, 2026
@docs-page

docs-page Bot commented Nov 2, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~852

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review November 2, 2026 08:41
@vypbot vypbot added this to vypdev Nov 2, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 2, 2026
@vypbot
vypbot changed the base branch from develop to master November 2, 2026 08:41
@vypbot
vypbot changed the base branch from master to develop November 2, 2026 08:41
@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on dca6114.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: dca6114af8cf; base: 9d3915729c96; reason: protected-path.

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.30%. Comparing base (9d39157) to head (dca6114).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #852   +/-   ##
========================================
  Coverage    95.29%   95.30%           
========================================
  Files         1125     1129    +4     
  Lines        37170    37242   +72     
  Branches     11092    11110   +18     
========================================
+ Hits         35422    35494   +72     
  Misses         672      672           
  Partials      1076     1076           
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...ation/policies/progress_partition_length_policy.ts 100.00% <100.00%> (ø)
...cases/actions/query_progress_partition_workflow.ts 100.00% <100.00%> (ø)
...usecases/actions/query_progress_result_workflow.ts 100.00% <100.00%> (ø)
...ecases/actions/summarize_progress_diff_workflow.ts 100.00% <100.00%> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
.../data/repository/progress_agent_response_policy.ts 100.00% <100.00%> (ø)
...ta/repository/progress_partition_length_failure.ts 100.00% <100.00%> (ø)
src/domain/progress_partition_length_failure.ts 100.00% <100.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…schema-string-long-and-no-file-identity: clarify unchanged progress completion equivalence

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:awaiting-maintainer state:ready

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Progress partition rejects per file implemented text with schema string long and no file identity

3 participants