Repository navigation
refactor(pages): consolidate adapter plugin lifecycle - #633
Merged
cpojer merged 2 commits intoOct 29, 2026
Merged
Conversation
yangshun
marked this pull request as ready for review
October 29, 2026 06:59
cpojer
self-requested a review
October 29, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React, Vue, Svelte, and Solid duplicate Pages scanning, virtual-module loading, watcher rescans, and module invalidation. Extract this lifecycle into
createPagesPluginthrough the existingvoid/pagesentry so fixes apply consistently across all four adapters.Each adapter retains its configuration, renderer/client generation, and current build-selection rules. Page-extension filtering remains unchanged and will be handled separately. Add 52 regression cases covering build selection, lazy discovery, static-data options, watcher invalidation, concurrent rescans, and error recovery.
Validation: