Repository navigation
fix: finish the last unfinished review items (wording, default date file, upgrade docs) - #626
Merged
Merged
Conversation
The provisioner and deploy steps run the `cf` CLI, but three provision errors still said "wrangler" and several comments still described wrangler 4.131. The CLI output rewrote the word before printing, so users saw the right text, but the source no longer matched what runs. The errors now name the Cloudflare config and Cloudflare tooling, and the comments describe current behaviour without the stale version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….json When a project had no config file and no date, the first dev server, build or deploy created a new void.json, a format the docs call legacy. Adding void.config.ts later then failed with "Found both". Now the date goes where the project already keeps its config: - a new project gets a generated void.config.ts with only the date, as `void init` writes it, and `.void-wrangler.jsonc` is added to .gitignore; - framework apps (Astro, SvelteKit, Nuxt, Analog) and projects with a root wrangler.json(c) get it in the root Wrangler file their adapter reads; - a project with wrangler.toml keeps getting it in void.json, because void.config.ts would hide the toml's bindings. A date already in void.json is still read, so existing projects keep their date. The .gitignore helper moves from `void migrate` to cloudflare-config.ts so both paths share it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Operators were not told to upgrade the platform before the team updates the CLI, although a newer CLI refuses an older platform. They were also not told that a runtime token from an older setup link lacks the Containers and Cloudchamber permissions that sandbox apps need, which an upgrade does not add. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-unfinished-tracker-items-void-cloud.voidzero-docs.workers.dev (commit dd0cd5f)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the last three "unfinished" items in the internal SDK review.
#274: where the default compatibility date goes
Only when a project has no config file and no date:
void.json. Addingvoid.config.tslater then failed with "Found both".void.jsonis still read, so existing projects don't change.wrangler.tomlprojects stay onvoid.json, becausevoid.config.tswould hide the toml's bindings..gitignorehelper moves fromvoid migratetocloudflare-config.tsso both paths use it. Its regex is now plain string checks.#248: wording only
--env=calls.#1052: docs
maintenance.md→ "Upgrade the platform":Verification
vp run check,vp lintandvp fmt --checkpass.vp run test: 748 files and 15,026 tests pass.🤖 Generated with Claude Code