Skip to content

fix(cli): reconcile Cloudflare Worker logging settings - #604

Open
TheAlexLichter wants to merge 2 commits into
mainfrom
fix/cloudflare-worker-settings
Open

TheAlexLichter wants to merge 2 commits into
mainfrom
fix/cloudflare-worker-settings

Conversation

@TheAlexLichter

@TheAlexLichter TheAlexLichter commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

At the moment, an existing Worker with logpush: false currently fails with Cloudflare Worker setting logpush cannot be uploaded with pinned secrets. Simply accepting the key would leave it unapplied.

This PR resolves it.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-cloudflare-worker-settings-void-cloud.voidzero-docs.workers.dev (commit 867b0f9)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://b3233c06-void-cloud.voidzero-docs.workers.dev 867b0f9 2026-10-29T09:24:40.015Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://59c95686-void-cloud.voidzero-docs.workers.dev 6f33d56 2026-10-27T01:45:16.935Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://783a88cf-void-cloud.voidzero-docs.workers.dev d39cb9d 2026-10-27T01:21:08.496Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://1a4bcc4f-void-cloud.voidzero-docs.workers.dev ecb8200 2026-10-27T01:07:38.108Z Visit the dashboard ↗

@cpojer
cpojer requested a review from Brooooooklyn October 27, 2026 01:06
@TheAlexLichter
TheAlexLichter marked this pull request as ready for review October 27, 2026 01:25
@TheAlexLichter
TheAlexLichter marked this pull request as draft October 27, 2026 01:34
@TheAlexLichter
TheAlexLichter marked this pull request as ready for review October 27, 2026 05:16
@Brooooooklyn
Brooooooklyn force-pushed the fix/cloudflare-worker-settings branch from 6f33d56 to 867b0f9 Compare October 29, 2026 09:23
@Brooooooklyn

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T09:25:08.388443Z 867b0f9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 867b0f9446

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants