Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an assertion is wrapped in
Error.cause, its message is shown but its actual/expected values are not available in the VS Code diff view. This addresses the remaining diff-display case discussed in #659.Keep a single message with the full cause text and retain the outer error's stack, location, and copy-output association. Existing checks for missing values and serialized
undefinedstill apply.Evidence
expected undefined to equal 'actual'.pnpm typecheck,pnpm build, andpnpm fmtpass./tmpuser-data and extensions paths to avoid the macOS socket path limit; it is not included in this PR.Merge Danger
Door: Two-way; a localized change with no persistent data changes.
Blast Radius: Testing. Only the selection of diff values for reported test errors changes; the outer error still owns the message and navigation metadata.