Repository navigation
Conversation
… lost answers, double hint bar - multiselect: "← Back" is an action row (no checkbox, skipped by select-all, Enter goes back); engine ignores out-of-range indices; stop the prompt program on abnormal exit - textinput: clear validation error only when the value changes; show the full placeholder - wizard: keep the previous answer as the prompt default after going back - remove the duplicate HintBarView from vm, network, auth, registry, objectstorage and settings wizards Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared wizard code had four bugs and a duplicate hint bar. Real terminal runs of the new
verda mk8swizards exposed them.Why it matters: two of them panic or hide errors, and every wizard (vm, network, auth, registry, objectstorage, settings, serverless) shares this code.
← Back(Ctrl+A, or Space on Back, then Enter)> dinstead ofdefault: 90 daysrewindOnecleared its answeresc cancelandesc backHintBarView, but the wizard already draws its own barcompositeModel.View() bus views (progress, summary) - HintBarView <- registered per wizard composite hint barEvidence
TestEngine_MultiSelect_BackIndexInResultDoesNotPanicfails withpanic: index out of range [1] with length 1.After: it passes.
After: they pass.
TestTextInputPrompt_ValidationErrorSurvivesNonKeyMessages: the error is still shown after a blink or resize message, and is cleared by typing.TestTextInputPrompt_ShowsFullPlaceholder.TestTextInputPrompt_PasteLongerThanPlaceholderIsNotClipped.TestMultiSelectModel_BackItemTestEngine_BuildPromptModel_MultiSelectBackIsNotAValueTestEngine_RewindOne_KeepsAnswerAsDefaultTestWizardLayoutHasNoExtraHintBarTestBuildCreateFlowHasNoExtraHintBarmake build && make test && make lint && make fix.checkall pass. I did not drive a real terminal on main. The mk8s branch showed these bugs live.Merge Danger
Door: two-way. It is code only, with no data or API changes. Revert the PR to undo it.
Blast Radius: every interactive wizard and text prompt.
settings themeandvm createin template mode now draw no hint bar of their own and no progress view, the same as before minus the duplicate.🤖 Generated with Claude Code