Repository navigation
Fix: serverless env variable feature update - #79
Merged
Merged
Conversation
…e deployment
The container env endpoints key on container_name = the container inside the
deployment, which the API names "<deployment>-0" (we never send a name on
create). env set/unset were sending the deployment name, so every add, update
and delete failed with not_found. Resolve the real container name via a
deployment GET (containerNameOf), the same way update already does.
The GET /environment-variables response is grouped per container
([{container_name, env[]}]); SDK v1.7.1 GetEnvironmentVariables decodes it as
a flat []ContainerEnvVar and yields one blank entry per container. Read the
grouped shape directly (fetchEnvVars via the SDK client) and pick the resolved
container's group. env list warns when a deployment exposes more than one
container. Drop fetchEnvVars once the SDK returns groups.
Tests serve the grouped response and assert container_name is the inner
container; adds a no-containers case and two multi-container cases.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bring container_env.go to full statement coverage (bar the unreachable NewRequest error branch): missing client, missing name without a terminal, failures on every env endpoint and on the deployment lookup, a container absent from the env GET groups, env-flag validation, unset confirm accept/decline/prompter-failure, and the interactive picker for list, set and unset including cancel, empty list and list-load failure. Also a unit test for envVarsOf. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
README gains a usage section for `verda container env` showing that every subcommand takes the deployment name and the CLI resolves the inner container. CLAUDE.md lists the env/secret/file-secret/registry-creds subtrees and the container_env.go file. `env list` gets an in-command example like set and unset already had. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ajmyyra
previously approved these changes
Nov 18, 2026
ajmyyra
left a comment
Contributor
There was a problem hiding this comment.
We oughta redo the API at some point. Not sure why containers even need names 😂
yutkin
reviewed
Nov 18, 2026
yutkin
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bug where listing deployment env variables worked with deployment name, but modifying required the internal container name as well as added tests.
Type of Change
Checklist
make test)make pre-commit)