Repository navigation
fix: treat ignored s as a literal character - #2938
Open
Plastic-time wants to merge 1 commit into
Open
Plastic-time wants to merge 1 commit into
Plastic-time wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2938 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Plastic-time
marked this pull request as ready for review
October 22, 2026 01:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isAlphaandisAlphanumericcurrently turn the literal string optionignore: 's'into the regexp whitespace class. For example,isAlpha('ab cd', 'en-US', {ignore: 's'})incorrectly returns true, while a literalsembedded in a Russian string is not removed.Remove the stray
sfrom both regexp-escaping character classes. String ignore options now remove the requested literal character; explicit whitespace, regexp metacharacters, and RegExp-valued options retain their behavior. This restores the existing README contract and introduces no API or locale-table change.Validation on Node 24.20.0 / Windows:
npm testafter the fix: Node/ES/browser/minified builds, ESLint, and all 331 tests pass.Duplicate check: open #2086 and #2087 refactor option signatures but retain the original escaping expression; their actual diffs do not fix this case. Latest master was checked before submission.
AI assisted the implementation and this description; a separate agent reviewed the final diff and tried counterexamples. No human review is claimed.
Checklist